From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752077AbdAaTKw (ORCPT ); Tue, 31 Jan 2017 14:10:52 -0500 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:40882 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751980AbdAaTKu (ORCPT ); Tue, 31 Jan 2017 14:10:50 -0500 Message-ID: <1485889841.3199.57.camel@HansenPartnership.com> Subject: Re: [tpmdd-devel] [PATCH] tpm: fix a sparse error in tpm-interface.c From: James Bottomley To: Jarkko Sakkinen , tpmdd-devel@lists.sourceforge.net Cc: open list , linux-security-module@vger.kernel.org Date: Tue, 31 Jan 2017 11:10:41 -0800 In-Reply-To: <20170131180742.28460-1-jarkko.sakkinen@linux.intel.com> References: <20170131180742.28460-1-jarkko.sakkinen@linux.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-01-31 at 20:07 +0200, Jarkko Sakkinen wrote: > drivers/char/tpm//tpm-interface.c:492:42: warning: bad assignment ( > -=) > to restricted __be32 > > Fixes: 0883743825e3 ("TPM: sysfs functions consolidation") > Signed-off-by: Jarkko Sakkinen > --- > drivers/char/tpm/tpm-interface.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm > -interface.c > index 423938e..746bc54 100644 > --- a/drivers/char/tpm/tpm-interface.c > +++ b/drivers/char/tpm/tpm-interface.c > @@ -489,7 +489,7 @@ ssize_t tpm_getcap(struct tpm_chip *chip, u32 > subcap_id, cap_t *cap, > tpm_cmd.params.getcap_in.cap = > cpu_to_be32(subcap_id); > /*subcap field not necessary */ > tpm_cmd.params.getcap_in.subcap_size = > cpu_to_be32(0); > - tpm_cmd.header.in.length -= > cpu_to_be32(sizeof(__be32)); > + tpm_cmd.header.in.length = cpu_to_be32(18); using bare numbers here without comment isn't really best practice. What about setting header.in.length in both legs of the if() to either tpm_cmd.header.in.length = cpu_to_be32(HEADER_SIZE + sizeof(struct tpm_getcap_params_in)) or /* setting subcap_size to zero allows us to elimnate the subcap field */ tpm_cmd.header.in.length = cpu_to_be32(HEADER_SIZE + sizeof(struct tpm_getcap_params_in) - sizeof(tpm_cmd.params.getcap_in.subcap))