From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752645AbdBCLsk (ORCPT ); Fri, 3 Feb 2017 06:48:40 -0500 Received: from mga03.intel.com ([134.134.136.65]:62991 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753039AbdBCLsh (ORCPT ); Fri, 3 Feb 2017 06:48:37 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,328,1477983600"; d="scan'208";a="39243646" Message-ID: <1486122366.2133.376.camel@linux.intel.com> Subject: Re: [PATCH v5 4/4] i2c: allow specify device properties in i2c_board_info From: Andy Shevchenko To: Dmitry Torokhov , "Rafael J. Wysocki" Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Mika Westerberg , Hans de Goede , Wolfram Sang Date: Fri, 03 Feb 2017 13:46:06 +0200 In-Reply-To: <20170203014128.317-5-dmitry.torokhov@gmail.com> References: <20170203014128.317-1-dmitry.torokhov@gmail.com> <20170203014128.317-5-dmitry.torokhov@gmail.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-02-02 at 17:41 -0800, Dmitry Torokhov wrote: > With many drivers converting to using generic device properties, it is > useful to provide array of device properties when instantiating new > i2c > client via i2c_board_info and have them automatically added to the > device > in question. FWIW: Reviewed-by: Andy Shevchenko > > Signed-off-by: Dmitry Torokhov > --- >  drivers/i2c/i2c-core.c | 16 +++++++++++++++- >  include/linux/i2c.h    |  3 +++ >  2 files changed, 18 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c > index f009549f86a5..3897e78e5e9a 100644 > --- a/drivers/i2c/i2c-core.c > +++ b/drivers/i2c/i2c-core.c > @@ -1335,15 +1335,29 @@ i2c_new_device(struct i2c_adapter *adap, > struct i2c_board_info const *info) >   client->dev.fwnode = info->fwnode; >   >   i2c_dev_set_name(adap, client); > + > + if (info->properties) { > + status = device_add_properties(&client->dev, info- > >properties); > + if (status) { > + dev_err(&adap->dev, > + "Failed to add properties to client > %s: %d\n", > + client->name, status); > + goto out_err; > + } > + } > + >   status = device_register(&client->dev); >   if (status) > - goto out_err; > + goto out_free_props; >   >   dev_dbg(&adap->dev, "client [%s] registered with bus id > %s\n", >   client->name, dev_name(&client->dev)); >   >   return client; >   > +out_free_props: > + if (info->properties) > + device_remove_properties(&client->dev); >  out_err: >   dev_err(&adap->dev, >   "Failed to register i2c client %s at 0x%02x (%d)\n", > diff --git a/include/linux/i2c.h b/include/linux/i2c.h > index 4aa7d244b38a..ec8f866a5656 100644 > --- a/include/linux/i2c.h > +++ b/include/linux/i2c.h > @@ -51,6 +51,7 @@ enum i2c_slave_event; >  typedef int (*i2c_slave_cb_t)(struct i2c_client *, enum > i2c_slave_event, u8 *); >   >  struct module; > +struct property_entry; >   >  #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) >  /* > @@ -310,6 +311,7 @@ static inline int i2c_slave_event(struct > i2c_client *client, >   * @archdata: copied into i2c_client.dev.archdata >   * @of_node: pointer to OpenFirmware device node >   * @fwnode: device node supplied by the platform firmware > + * @properties: additional device properties for the device >   * @irq: stored in i2c_client.irq >   * >   * I2C doesn't actually support hardware probing, although > controllers and > @@ -331,6 +333,7 @@ struct i2c_board_info { >   struct dev_archdata *archdata; >   struct device_node *of_node; >   struct fwnode_handle *fwnode; > + const struct property_entry *properties; >   int irq; >  }; >   -- Andy Shevchenko Intel Finland Oy