From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752529AbdBGDaU (ORCPT ); Mon, 6 Feb 2017 22:30:20 -0500 Received: from mga01.intel.com ([192.55.52.88]:34829 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751728AbdBGDaS (ORCPT ); Mon, 6 Feb 2017 22:30:18 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,344,1477983600"; d="scan'208";a="61984859" Message-ID: <1486438213.2645.1.camel@intel.com> Subject: Re: [PATCH] Thermal - Fix possible NULL derefrence. From: Zhang Rui To: Shailendra Verma , Eduardo Valentin , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma Date: Tue, 07 Feb 2017 11:30:13 +0800 In-Reply-To: <1485752698-30248-1-git-send-email-shailendra.v@samsung.com> References: <1485752698-30248-1-git-send-email-shailendra.v@samsung.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Just one comment, the subject should be  [PATCH] Thermal: imx_thermal : Fix possible NULL derefrence On Mon, 2017-01-30 at 10:34 +0530, Shailendra Verma wrote: > of_device_get_match_data could return NULL, and so can cause > a NULL pointer dereference later. > > Signed-off-by: Shailendra Verma I think Eduardo will take this patch. thanks, rui > --- >  drivers/thermal/imx_thermal.c |    4 ++++ >  1 file changed, 4 insertions(+) > > diff --git a/drivers/thermal/imx_thermal.c > b/drivers/thermal/imx_thermal.c > index 06912f0..fb648a4 100644 > --- a/drivers/thermal/imx_thermal.c > +++ b/drivers/thermal/imx_thermal.c > @@ -489,6 +489,10 @@ static int imx_thermal_probe(struct > platform_device *pdev) >   data->tempmon = map; >   >   data->socdata = of_device_get_match_data(&pdev->dev); > + if (!data->socdata) { > + dev_err(&pdev->dev, "no device match found\n"); > + return -ENODEV; > + } >   >   /* make sure the IRQ flag is clear before enabling irq on > i.MX6SX */ >   if (data->socdata->version == TEMPMON_IMX6SX) {