From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932268AbdBHG6d (ORCPT ); Wed, 8 Feb 2017 01:58:33 -0500 Received: from mout.gmx.net ([212.227.15.19]:54427 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932096AbdBHG6b (ORCPT ); Wed, 8 Feb 2017 01:58:31 -0500 Message-ID: <1486537024.4387.4.camel@gmx.de> Subject: Re: v4.9, 4.4-final: 28 bioset threads on small notebook, 36 threads on cellphone From: Mike Galbraith To: Kent Overstreet , Pavel Machek Cc: Mike Snitzer , kernel list , axboe@fb.com, hch@lst.de, neilb@suse.de, martin.petersen@oracle.com, dpark@posteo.net, ming.l@ssi.samsung.com, dm-devel@redhat.com, ming.lei@canonical.com, agk@redhat.com, jkosina@suse.cz, geoff@infradead.org, jim@jtan.com, pjk1939@linux.vnet.ibm.com, minchan@kernel.org, ngupta@vflare.org, oleg.drokin@intel.com, andreas.dilger@intel.com Date: Wed, 08 Feb 2017 07:57:04 +0100 In-Reply-To: <20170207204510.qr2l2rg42ez2hobh@moria.home.lan> References: <20151211104937.GA23165@amd> <20151211140841.GA22873@redhat.com> <20160220174035.GA16459@amd> <20160220184258.GA3753@amd> <20160220195136.GA27149@redhat.com> <20160220200432.GB22120@amd> <20170206125309.GA29395@amd> <20170207014724.74tb37jj7u66lww3@moria.home.lan> <20170207024906.4oswyuvxfnqkvbhr@moria.home.lan> <20170207203911.GA16980@amd> <20170207204510.qr2l2rg42ez2hobh@moria.home.lan> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:T+II8MBBJsLFQFFEBZxSGEbygkMiO8nEriQDoFQ+arLx60EF20s addGFtRNlIiSNpG6iphFzzdETsrNE4wrsxiHjY6uL6gHdxbN6jpIOOAMkhxHTj7P6KzObwn eHj98l0JtnnGveUxc9b3p2SOm6DT0rwVnUyToBgZ06MzEDRpuKWPW/EumKJYOQkPpsg/xYM w5fb9btk/nVM57Dv6sRwg== X-UI-Out-Filterresults: notjunk:1;V01:K0:4qAA7C4fKcI=:0aFnN4RpcQjJ0ZSQ1pm6Sr LNmYeiGT++PTut5a2wM2t2WBJM81hVjfoX5oCzWc/XHzsMzcOiAgjYSNGwYnD6TFUfBFNFjFD tvTVppAdAcWl6VfjMz3UegBJZXya5tj7Ei2XpvgNJEoyk8qse3zcRn3VxRK314TvVRULxuude BY/cuNTj/QbwEYYWv8rxTO2JoLgWxSh2l0SSl+O24oiB+fgCteAkP5e7oZDJU7RDkZ3RI+dK6 mOnYaTFFjI9PAmRz2cmd1ctcbmiml4BWtoM/loF2Tec803sOzKeUP/9vdTXmPs7gv5f8tA3Di Kik8HaG1RqlI9lzdS+ToSXFYMZ9gEQvUUMZCv0ucFhINz345yNZHOJtp8ak4DPmAO45AaRlH4 K+uHoP7Gf8Hegiqor83Wr4aUs54cgp28615Soz55G8uPKzNADGg+hZ2vkjPEcf9i9c5SPqvRV Y4v2lt4oe8W251MaZIlkjtak4J2gk7UNgngUFzf8U1Wj5LQ96cghGTqAzVuPlKExwT6Gkoa1V XSyz/O6ReB+YJgsq4Bye+whBkIS7L9cc60SIy3J7OfGdfCKqIWvvWUYNrjU46KXGy9tM5DaJU 8iKZl/MDATQmQXLpIG7SoZrMLZwQEUQh5w58XTQqK+S/cyDMpQ+JB8wlq1UCcB81FApb4Z9jR 4gkKZZu8pbqH+krAOafStnhWGy2eOX1SqtmsF0/E6BColuwezKPYXxjsUtl2nT2WF4VyL1n6E N1iSa+UG7a+1PyosPAO6q+hZkmSlsuPmgCAlwwS2A03lUKGt+vrqnp1RsWn0Dh7vaG0a0hJIT DpKC15q Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-02-07 at 19:58 -0900, Kent Overstreet wrote: > On Tue, Feb 07, 2017 at 09:39:11PM +0100, Pavel Machek wrote: > > On Mon 2017-02-06 17:49:06, Kent Overstreet wrote: > > > On Mon, Feb 06, 2017 at 04:47:24PM -0900, Kent Overstreet wrote: > > > > On Mon, Feb 06, 2017 at 01:53:09PM +0100, Pavel Machek wrote: > > > > > Still there on v4.9, 36 threads on nokia n900 cellphone. > > > > > > > > > > So.. what needs to be done there? > > > > > > > But, I just got an idea for how to handle this that might be halfway sane, maybe > > > > I'll try and come up with a patch... > > > > > > Ok, here's such a patch, only lightly tested: > > > > I guess it would be nice for me to test it... but what it is against? > > I tried after v4.10-rc5 and linux-next, but got rejects in both cases. > > Sorry, I forgot I had a few other patches in my branch that touch > mempool/biosets code. > > Also, after thinking about it more and looking at the relevant code, I'm pretty > sure we don't need rescuer threads for block devices that just split bios - i.e. > most of them, so I changed my patch to do that. > > Tested it by ripping out the current->bio_list checks/workarounds from the > bcache code, appears to work: Patch killed every last one of them, but.. homer:/root # dmesg|grep WARNING [ 11.701447] WARNING: CPU: 4 PID: 801 at block/bio.c:388 bio_alloc_bioset+0x1a7/0x240 [ 11.711027] WARNING: CPU: 4 PID: 801 at block/blk-core.c:2013 generic_make_request+0x191/0x1f0 [ 19.728989] WARNING: CPU: 0 PID: 717 at block/bio.c:388 bio_alloc_bioset+0x1a7/0x240 [ 19.737020] WARNING: CPU: 0 PID: 717 at block/blk-core.c:2013 generic_make_request+0x191/0x1f0 [ 19.746173] WARNING: CPU: 0 PID: 717 at block/bio.c:388 bio_alloc_bioset+0x1a7/0x240 [ 19.755260] WARNING: CPU: 0 PID: 717 at block/blk-core.c:2013 generic_make_request+0x191/0x1f0 [ 19.763837] WARNING: CPU: 0 PID: 717 at block/bio.c:388 bio_alloc_bioset+0x1a7/0x240 [ 19.772526] WARNING: CPU: 0 PID: 717 at block/blk-core.c:2013 generic_make_request+0x191/0x1f0