From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751756AbdBHUR3 (ORCPT ); Wed, 8 Feb 2017 15:17:29 -0500 Received: from mga03.intel.com ([134.134.136.65]:39615 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbdBHUR1 (ORCPT ); Wed, 8 Feb 2017 15:17:27 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,348,1484035200"; d="scan'208";a="222961925" Message-ID: <1486585012.2133.420.camel@linux.intel.com> Subject: Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver From: Andy Shevchenko To: Richard Leitner , Richard Leitner , Greg KH Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, stern@rowland.harvard.edu Date: Wed, 08 Feb 2017 22:16:52 +0200 In-Reply-To: <3902c4a9-cd1d-23fe-df75-127b5cab61ad@g0hl1n.net> References: <1486543976-28006-1-git-send-email-richard.leitner@skidata.com> <1486560068.2133.395.camel@linux.intel.com> <20170208135957.GA916@kroah.com> <96c8a6f9-3b93-8ba0-22b1-502e22dac31c@skidata.com> <1486572009.2133.406.camel@linux.intel.com> <80e533b6-4eb3-0019-fe18-82dd0d7aaa1c@g0hl1n.net> <1486581644.2133.409.camel@linux.intel.com> <3902c4a9-cd1d-23fe-df75-127b5cab61ad@g0hl1n.net> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-02-08 at 21:03 +0100, Richard Leitner wrote: > On 02/08/2017 08:20 PM, Andy Shevchenko wrote: > > On Wed, 2017-02-08 at 19:45 +0100, Richard Leitner wrote: > > > On 02/08/2017 05:40 PM, Andy Shevchenko wrote: > > > > On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote: > > > > > On 02/08/2017 02:59 PM, Greg KH wrote: > > > > > > > Should I keep my inline {clr,set}_bit_in_byte()  > functions an use BIT() in there, or delete them and use BIT() > directly  > in usb251xb_get_ofdata() ? Does it make any sense? Even just name of your function is longer than what it substitutes. -- Andy Shevchenko Intel Finland Oy