From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932499AbdBPQDg (ORCPT ); Thu, 16 Feb 2017 11:03:36 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:59282 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754616AbdBPQDe (ORCPT ); Thu, 16 Feb 2017 11:03:34 -0500 Message-ID: <1487261005.22520.5.camel@decadent.org.uk> Subject: Re: [PATCH 3.2 086/126] igmp: do not remove igmp souce list info when set link down From: Ben Hutchings To: Hangbin Liu Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, akpm@linux-foundation.org, "David S. Miller" Date: Thu, 16 Feb 2017 16:03:25 +0000 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-tIAyljw0i1ATwVF8FIq5" X-Mailer: Evolution 3.22.4-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-tIAyljw0i1ATwVF8FIq5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2017-02-16 at 09:42 +0800, Hangbin Liu wrote: > > 2017-02-16 6:41 GMT+08:00 Ben Hutchings : > > 3.2.85-rc1 review patch.=C2=A0=C2=A0If anyone has any objections, pleas= e let me know. > >=20 > > ------------------ > >=20 > > From: Hangbin Liu > >=20 > > commit 24803f38a5c0b6c57ed800b47e695f9ce474bc3a upstream. > >=20 > > In commit 24cf3af3fed5 ("igmp: call ip_mc_clear_src..."), we forgot to = remove > > igmpv3_clear_delrec() in ip_mc_down(), which also called ip_mc_clear_sr= c(). > > This make us clear all IGMPv3 source filter info after NETDEV_DOWN. > > Move igmpv3_clear_delrec() to ip_mc_destroy_dev() and then no need > > ip_mc_clear_src() in ip_mc_destroy_dev(). > >=20 > > On the other hand, we should restore back instead of free all source fi= lter > > info in igmpv3_del_delrec(). Or we will not able to restore IGMPv3 sour= ce > > filter info after NETDEV_UP and NETDEV_POST_TYPE_CHANGE. > >=20 > > Fixes: 24cf3af3fed5 ("igmp: call ip_mc_clear_src() only when ...") > > Signed-off-by: Hangbin Liu > > Signed-off-by: David S. Miller > > [bwh: Backported to 3.2: > > =C2=A0- Use IGMP_Unsolicited_Report_Count instead of sysctl_igmp_qrv > > =C2=A0- Adjust context] > > Signed-off-by: Ben Hutchings >=20 > Hi Ben, >=20 > There is a bug fix for this patch, please consider drop this patch or > include the fix. >=20 > commit 9c8bb163ae784be4f79ae504e78c862806087c54 > Author: Hangbin Liu > Date:=C2=A0=C2=A0=C2=A0Wed Feb 8 21:16:45 2017 +0800 >=20 > =C2=A0=C2=A0=C2=A0=C2=A0igmp, mld: Fix memory leak in igmpv3/mld_del_delr= ec() [...] Thanks. As the second fix is quite recent, I'm going to drop this patch for now (from both 3.2 and 3.16) and consider applying both of them in later updates. Ben. --=20 Ben Hutchings The most exhausting thing in life is being insincere. - Anne Morrow Lindberg --=-tIAyljw0i1ATwVF8FIq5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAlilzU4ACgkQ57/I7JWG EQmgfw/9E493ysQGwNqoRYfujcEVmAp+HVjvyMvWTUdGSV8z3UhgRkRhJfrEXUXF WSjF4nsm3A72dQibAEaG+ZVkNecEEE6EJkSCio+6ZVVJ5YevE5NZgubhys0tuyqZ PyKxj2bDJhcXAgHubL4zPcPdK3+hWnvkkcU9ZMCs6tgzVj0U+rIPDeKjPVvb4TI9 BBq0yQiSCvSgIKgl4HdH6uQR+StgluTwK9AJIQrwrlbQcaOAo1JaV6gpYWR8iCkw iIq+Dr2gA2ckj/w+fsKba5zr8pnRCImYZGpLZ/g0zQXOOrHTsA5FRNaaa8RvPnkv sc48hmMayP9Mgn55yZ8tiVzfS0DDYF4RPsR9FFcFcLHUJz9eui7G1rP2cz20mjF9 8NAJSM1x3jogJ3uJwUr0K7hv9U5rk46/qBzVTqow+gbd2LLwCp13A021btJlnAAi wbWB8jvJyicwk3a1C/LwDs9gWmEv8pfm5yFnD69JcbKdZkNPCcw/0BR0mGpVznSf mnIt6VTgB0HuzwPQCagfROu4howBWD7JH9pzXdhIZ/goNoPqSJ7BabBJddi1tzVQ R+0SC/iHju/rDnMimZ3042MR/93F4mOJiyNUfYC1QKtezAAGDTPfh9rtGR9f1h4b AfYoRjwatWRb13JQMMzi7Duy/8z+noV3/dMqtmyX0WkDiqM+2j0= =QVmQ -----END PGP SIGNATURE----- --=-tIAyljw0i1ATwVF8FIq5--