From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753467AbdBTOyV (ORCPT ); Mon, 20 Feb 2017 09:54:21 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:56903 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751341AbdBTOyT (ORCPT ); Mon, 20 Feb 2017 09:54:19 -0500 X-ME-Sender: X-Sasl-enc: hj4gw5gdyhSXvvtG4eFemKuaj3E3buLjIEI7oCz3iRDI 1487602387 Message-ID: <1487602379.21631.2.camel@aj.id.au> Subject: Re: [PATCH] ipmi: bt-bmc: Use a regmap for register access From: Andrew Jeffery To: minyard@acm.org, =?ISO-8859-1?Q?C=E9dric?= Le Goater Cc: Joel Stanley , openipmi-developer@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 21 Feb 2017 01:22:59 +1030 In-Reply-To: <1fe8fe1f-e035-8ef1-cecd-d3d29bcda075@acm.org> References: <20161206025715.2002-1-andrew@aj.id.au> <36014e0c-82f8-eeaf-ee2a-6c1e413b957d@kaod.org> <1487565939.3779.4.camel@aj.id.au> <1fe8fe1f-e035-8ef1-cecd-d3d29bcda075@acm.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Toj+iV271ijO4SqQQ4Sd" X-Mailer: Evolution 3.22.1-0ubuntu2 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-Toj+iV271ijO4SqQQ4Sd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2017-02-20 at 07:35 -0600, Corey Minyard wrote: > On 02/19/2017 10:45 PM, Andrew Jeffery wrote: > > Hi Cory, > >=20 > > On Tue, 2016-12-06 at 16:02 +0100, C=C3=A9dric Le Goater wrote: > > > [ this is a resend bc of some mailing list issues] > > >=20 > > > On 12/06/2016 03:57 AM, Andrew Jeffery wrote: > > > > The registers for the bt-bmc device live under the Aspeed LPC > > > > controller. Devicetree bindings have recently been introduced for t= he > > > > LPC controller where the "host" portion of the LPC register space i= s > > > > described as a syscon device. Future devicetrees describing the bt-= bmc > > > > device should nest its node under the appropriate "simple-mfd", "sy= scon" > > > > compatible node. > > > >=20 > > > > This change allows the bt-bmc driver to function with both syscon a= nd > > > > non-syscon- based devicetree descriptions by always using a regmap = for > > > > register access, either retrieved from the parent syscon device or > > > > instantiated if none exists. > > > >=20 > > > > The patch has been tested on an OpenPOWER Palmetto machine, success= fully > > > > booting, rebooting and powering down the host. > > > >=20 > > > > Signed-off-by: Andrew Jeffery > > >=20 > > > It would be nice to have an example of the associated binding. > > > I did not see it. A part from that : > > >=20 > > > Reviewed-by: C=C3=A9dric Le Goater > >=20 > > Will this make it into 4.11? >=20 > I thought you were doing a v2 with a few little fixes.=C2=A0=C2=A0Get it = to me=C2=A0 > quickly, if you can. Reading back it was a bit ambiguous. No worries, I'll roll in the small fixes and send a v2. Cheers, Andrew --=-Toj+iV271ijO4SqQQ4Sd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIcBAABCgAGBQJYqwLLAAoJEJ0dnzgO5LT57NMQAJMrEXf2gqorSugxKQfRbezI g6C/T54bZoshVxvIPQYa8STzQhipPm6HQSAquLYAuuz1IXnjqR979g52mlvi/7m6 Tg8kQDCUWtWlcHwBTSTttuKmu2mzBB06hy7dppb57DyUK6wzjzN2WPpN4BON3kOR StPkOAStLdHtvo1MrC8gq+xDicyEHPxR8+r121Myg9uPb9GS2qfRMGswwbb8U+vl R0PFDnAUjWNyM3bmRz7i0H33q1sdi4Sv/2mhbURfTY8fJ4PbeiSWsOuBbY20ZAmH XTLnZLSMx1mBu83VmuCeufxoMR/qP1wfjy9Q29VDSrzafrKbjFVReBwwmmil377C jVenk2c9K2A9aDLPp4mvNm5tv5YuZ/ZKOcxYvzjPOHkcZ03XsFM1YVIFWGcfM0JL iwJmyOZ8pPuJkwqEMEZR0V4BGf+OQTXIoz0AxO7YaIs3G8hJtEr44ZJmEQsYPEAj lU7eusN2vtgzBfzRYPAYIxra0Nv04P1RVuKpkil/SHueO0EobZyJUuhglztZKjOC EtjlLDQYQm2JvifaSUY+oJgR3Bys0IMhyd7m+08AVmpUqzWLUaZ7ebmJ7VT7Yny3 5TXt0l+VXpV7ERl6yb68HVoWUu+PIQi2korGRVxdW7NhLwk0gMim6nhpQ+hipHYQ AgyK/dEtYiTU1hmnHmK1 =C9Tq -----END PGP SIGNATURE----- --=-Toj+iV271ijO4SqQQ4Sd--