From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932619AbdBVQZR (ORCPT ); Wed, 22 Feb 2017 11:25:17 -0500 Received: from mail-dm3nam03on0077.outbound.protection.outlook.com ([104.47.41.77]:22046 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932493AbdBVQZK (ORCPT ); Wed, 22 Feb 2017 11:25:10 -0500 Authentication-Results: spf=pass (sender IP is 204.128.141.23) smtp.mailfrom=infinera.com; kroah.com; dkim=none (message not signed) header.d=none;kroah.com; dmarc=bestguesspass action=none header.from=infinera.com; From: Joakim Tjernlund To: "greg@kroah.com" CC: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH 1/2] Correct function definition for C++ Thread-Topic: [PATCH 1/2] Correct function definition for C++ Thread-Index: AQHSjFaMuPJoCVccYkCF9+ON7YxfW6F1IuUAgAALRwCAAFdVAIAAEBSAgAAF+gCAACJRAA== Date: Wed, 22 Feb 2017 16:25:05 +0000 Message-ID: <1487780704.5760.24.camel@infinera.com> References: <20170221152405.7552-1-joakim.tjernlund@infinera.com> <20170222071022.GA9186@kroah.com> <1487749844.5760.17.camel@infinera.com> <20170222130318.GB15769@kroah.com> <1487772051.5760.20.camel@infinera.com> <20170222142214.GA6830@kroah.com> In-Reply-To: <20170222142214.GA6830@kroah.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.100.99.93] Content-Type: text/plain; charset="iso-8859-15" Content-ID: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:204.128.141.23;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39450400003)(2980300002)(438002)(24454002)(377424004)(199003)(189002)(106466001)(38730400002)(106116001)(93886004)(23756003)(2906002)(102836003)(2351001)(2900100001)(3846002)(110136004)(6916009)(54906002)(356003)(7736002)(2950100002)(76176999)(50986999)(5640700003)(7636002)(54356999)(2501003)(77096006)(305945005)(5660300001)(6116002)(1730700003)(8936002)(53416004)(36756003)(92566002)(4326007)(8746002)(8676002)(6246003)(103116003)(50466002)(626004)(189998001)(86362001)(33646002)(47776003)(229853002);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR10MB1551;H:owa.infinera.com;FPR:;SPF:Pass;MLV:nspm;A:1;MX:1;PTR:outgoingmail1.infinera.com;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2NAM03FT059;1:3RlWZnvA0fEG3adjAdAnxWQ9UNaZykRw5tlJ9GfteUKPIizOtHlZekSZxyZngZVX3kecSl15KY/33TwM65JJU2p2oXu6h6IMMTZkg2EjgRyGv6NPu1vWzB8MuZCg9sm3NdVQI6Hwgq1qQAlaO4/MQL67rwVugASNTtTp9S9Z9nDCaI+sKjDFa/I9nRb0o00kOC04rrpWEmbtrr8YMlI2tXsyFRTq7eDdUbEN876dHAqO59dZBdL5+IKl2n+15quOiSqNH/V1Be5dQKFDYywp8f6IbbjCpznCzsaAhYF0JlaGJ7j2X7mj2ol4ZJgbh2XMLJkpNwz+LoYj7xlRSeqYLRZxbxJKrh4xULsR+snmEew6En+iGTOfGPApuRE1musq0SdyqtBfSgJ63p5SknqndHfan8X81Ge+AVg4GVQ5PGGC6EY7svPSOXPthIuyFk8P5xnJnSth2RCV8S80W5d2LWDYx8Zh87LQxNVOgDOmHmFXR92gchK9PSbnKkH/vTdlXLgqdti4FuKRxvPKQVRelOhnHERLXJt1WCXUSZG7IZI= X-MS-Office365-Filtering-Correlation-Id: 6400d12b-12ef-4410-4639-08d45b3f5d74 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:MWHPR10MB1551; X-Microsoft-Exchange-Diagnostics: 1;MWHPR10MB1551;3:oWeSawqTyh+q3DISVLdTQMStiJl4ZSMaN5g29Xa6xZ6orNFXAjko4tGt67gm2DcMW7jc5vi7HYa3Xry79tqDwsUwoLIiTW6nCEUT0n9WzT0YHiwXGpQIQyf52J34wM/udkMr6ZhzBj3YPLmVtdgn7g+7G44vdGrqcd3Wb69s+RzSZ8GyQJg5UBHai2XfH5FQGi9z2CqJ4DkT86+mpXUZpE93F3F4KefuTND7TH2eIaEJvQAk3NB1BXXhUaCIHUSZ51M7vRk1JgvCUAaZg6upGixgKJAKnrEAK/kXucil7j/e/twBwh4xxolbVSkYI2tWAEW2oIHAVb/pq7XRu53fVTLvWc02rp1a8UawkR1X0Xxc33VXfxgDBNlGcy+7IHTwPvaFzo3xfhIYcyYP7WpmFw==;25:fmZjweAoDK2tXw2Sc+PSnsPaZ5724ygbBv5jcy3ERQKiUVvu44R5BNT+vQT7yI/jp/Q85ySO/RAxv3zdxw1sG1C7LtsObdz4te5XptXscH7/QAALMMOTgF24kw+XehEmVBR7AVL4Srdsr8Df+wyCBeO+LL+5FiVDDX9YCGoOxKJom4KwqSHw0cgeQNldfgYA0XIJUB+af7Py0aL8ZUfQPSvKapK5DQTZgT8j+hjMOiq35vmyjttGK9+zlBdU7Ma3+xhmp/sixRuvXU9cKAhhwaJWnW4mLWmQa6cEhJGUbfbuvRafo16a2LWWVddACy2M1XALHgHGIEFr73Mip5RW05Sqn0gVIbcwK5TVs2sfN8Qq/49wOHKX3TswklQPDZ4sv2ILvE3BYDwdfnsE9XB3w/qbZyLom6xrZ7Mh33ZgEwfD1j29HSOqnyp0iqkYT1K4FitDIjmrlWT7oPpZYhkeww== X-Microsoft-Exchange-Diagnostics: 1;MWHPR10MB1551;31:t8RTpXQSOyfjv5iI5C++x921paMK3Qc3r5+XfUaQfEZCS0H4mhKjhhkYj4lWGMLGfXn9/hLtQsyno5t4XHL7dPyf7z19JJx7ZmkHsT7CbINno/bXXZkJ8VS7hXQp9sV+MbacPf9CQkTlpJXtgBJ8T9epR6nhvIk9e9fVu75LMCPH6AfItXppVdf+FygFae+fO19nLxvWFguU4t9M/cwfdrotCj/L46J/NehdD3GtUArigi2+9kk3eNGmCdczxNv5ksqocVNufSsQiclPGXtZEA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(13018025)(8121501046)(5005006)(13017025)(13024025)(13015025)(13023025)(3002001)(10201501046)(6041248)(20161123555025)(20161123562025)(20161123564025)(20161123560025)(20161123558025)(6072148);SRVR:MWHPR10MB1551;BCL:0;PCL:0;RULEID:;SRVR:MWHPR10MB1551; X-Microsoft-Exchange-Diagnostics: 1;MWHPR10MB1551;4:ETHSrypfq3FnoeCxR3naGkfGbbml4CDZhI6rRa+ZUAOR3RPNr7duE3dhz2kNAVhINW6Tah+jiwEArc3gnafP6PpnljY9kGURx2KdNof2OFsOpfOtUX/N6jYGvYILe+Vshr3zUMnUEWLvQCtC1zsTlq4Qtz2+b9Zq7EZ/8k2jWqwk1JZLgp6nSCgZQLcnh+stVmVq8yjSrgPgwKiN/HAYC/r/YyisEBKiXcApLQjg6Fw5uUC/MwgEdNzdoQLZMvymxdmBb1gIYqeEh4v83GXcVwkmmeZCnGdtXrQTfarZdEr7bjJn1w89/+VuGRTdlBIHo/GGZL6vqMf1y69eiR/mxgqIVgGLLPjhNMJC76koPsP+UbD6UTwYBOfk8AIX9wCcKQrjyiexwH1NlP84BTSZ6Jsdedsr/Kk+urBfZ+4xfK3KcQ1EI0b38u7d07LeEdDcfjTJK3RMFndeBTorrFWh033bLIVVhzhC+PSSourgd4jE7bbC5EZhNT9ncbjvbVOk+bAipNdK8z8kYdPQDkGHJXq7F+UGo4x8PDjJrI/kYCQRtjWoaN6RG4+lwQX+rLkybfAQpPpnq7R0fQdNE2Uzmf68XgOYyKdPzstJzBNY2BTNsJet58LWTAKl2Ie/m1Pe6QfU8oCNqnexjVMXeYwLmHsyKa01WUqP+61+iuAfWa3kRjpixvkzuTwqNqU2ElHrSVqz5Gj06r+yWBaoTCA9Zw== X-Forefront-PRVS: 022649CC2C X-Microsoft-Exchange-Diagnostics: =?iso-8859-15?Q?1;MWHPR10MB1551;23:mhU+OWZe4ctewzRQMRtHiSwpF2OTgzB2NIQMOx?= =?iso-8859-15?Q?L8GdJ+9RX4bbpAYNlm9NGW33TAHHKNr2AaCEuqyQmRTW96k0yo3QCZ9qh?= =?iso-8859-15?Q?7y3rvS3nkSYA1xhMS+uXxBHSWfr6+pDHNnfPmraVMMfnIdrUWVGubDtCZ?= =?iso-8859-15?Q?YnQmyyo80CtzS59ZSC41UAUCiGLY32MNIMi6AVLzlH16J6TwKqXRCAPdc?= =?iso-8859-15?Q?X15tTC3zt+vAHOWFp2BqAXleCZDrlPdYd2jAlJWajQ81hcJTV+ZU+I4q4?= =?iso-8859-15?Q?7lk+2Z9+Xg5IrP9VM3N6Uwn2HgnKh4oVMvbs3Juka4tjVTynF+/Hsmp3/?= =?iso-8859-15?Q?luomWBFCLGTHLHvN5cCq22XpsAjmAz0umgdSUsLs+EDIOrjJYnyEAzOio?= =?iso-8859-15?Q?pWS8nJVb6/s0jGPsPjhjyLEbjUU3QzjrSUzdpVwqrGnicCyQFcjxXLpcB?= =?iso-8859-15?Q?ou2VYu2LNF4EOuzIJ7L/ooJGK/BnVX5dO+G2yEhl3aCHHMeQSuidUStoz?= =?iso-8859-15?Q?VG7vKQDjHA/rkZJG1K18gPbHBiLWErnfHiyJuLzy6bAWiqdubg2c0WkIw?= =?iso-8859-15?Q?20dXy+IT76H/Ta9jt0OqqvFYkbZF00fPQuenbQHL8VHyAzeoXoxqVhWN9?= =?iso-8859-15?Q?FkrFbX/jZ+MPiwdz8O+HVlyCYo9x3BQFy2ucTxil3clOUi9M5yZcR0dJy?= =?iso-8859-15?Q?NGAiP/ByVwR8qjPTxc5RpJV+Ph2l/r+4xMvSkkSBpLCDSPX691y3QQA/F?= =?iso-8859-15?Q?WjZmSDurA4iEtqt8o0CHYq1Tffk0aBhyJUQVmDZ2n3Au/J0qQVjZV7Oka?= =?iso-8859-15?Q?MShz/W6epNz2wRFd8ACoL1MsBGeixE/JDfgBrP66hZv1fPCa5QN41GCGg?= =?iso-8859-15?Q?vCcyGyGxGRVgrxPy8Vp9iZUmU1Z34VlTM7f5pBgx2lDbSVxf6Ni2NH2/M?= =?iso-8859-15?Q?7esCu6o2+PCoHOwDxGBsRLbQrcBDyZz00YUbaICbSk32ROYQsKJWTVa+8?= =?iso-8859-15?Q?hu+ABVPaddPsn4bRMK5NbtNujNoc73C0mH9kZYy8Th9scM6aWVotAXfCP?= =?iso-8859-15?Q?S5qDcX6ozr2A2x2yINwKhM1YD1pDvMvCH5J5LMu6bh4/EiWkGxMe6IfDO?= =?iso-8859-15?Q?CX4NKFgH3aQ34Ym8esEFAzYSZxFLJbEXhDzPk55ZDhsp6sfkMofZ7H2lA?= =?iso-8859-15?Q?lVx6fDPuiuF62MNSXlo2xSD5Q1TFdGSMLfHFpD6M+JfY0ujk0zIU8Vsqm?= =?iso-8859-15?Q?IGWDCqhQdAD7hFiaKQ6mwTddEJURGTaSd0inTfb9CJNA7CjLfN3Fp9y93?= =?iso-8859-15?Q?1Hw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR10MB1551;6:g8Ho4f0wNZinRDQJxyFsxaX742toi95IGGYcaz0F+39wLon1o94XZqDhQDoyxV8oHTydo/i/vVbG9TB4OMkmDKo1S53CDM+Oa408alLniL4gc97x9/s4raRoxyiFBPLhRrd3RBSXVcep2F7yYHCQD7MBERqesLYiJmDmBpOYWhdQJuuCN+eNHAcvGrBWjWAHb10Mf3e7o3MUBN76WeODpUQKhMPwcCDd5eTRuGgEcLN26y4Eg0HOOJDqj7Ud0GnnQ4tbvtMN8pW9uiubQkRFtlZwmkyFAkcjFnbAqr+OslPa6+/d2j6AmVP+9hVIguT6GURVPnYEt/Z1YDA2PmbSb3c4hx8EjLjiZ3PkAt6NLfiKoufJh8A29VCW/HXK62BWMxsuwCRU42RgAZQU/LRGqg==;5:aUVuIC2qBjSES3zR1quMuGlFguJC59NzerswaFfvFgDE1tHLqJDO5zoGofLqtzMwfeL6cJp4z/gBHWyT2fvXv/scaGlfu4KffHj49QyCl+VWv1mT+6lLxHLSd8hbYruGP6KHUnK8DEBHzcwqxEeKgQ==;24:a2YdNqogeCe+F4ITxM6sRDqTDcMvomCSCx8YN8c8/SGHPxzIwcruI9e+DVrnAWG8xvkUJzctVjFV5VRQvvzxFzW+m30ry3qH+HcI+ZFo4FQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR10MB1551;7:TZIP2KaPB331mrddCuD+GIS++n3EtswAYSE9/wPeWviq+TJwAt6cyolwt2T0cCf49JDqs3crfv9Ao1bxBR47qjUCCyehyJ9gHxEEJufUDd5ZwldmgpGk+e4cWUk/7piyY3KMvy9dw+60Wwb0WooBgMx+IvSysytLtcyiWM5C34zPdFsLUz18hnGmGh2JcObCHD3JDvFd6QkfNFSdxAwyHVu/++NruO1bLmetFNNSpof91fFLlOWgA1mZld2svfqqq8PQoGtPoU2WUm1BBMXBYwAUAuOUjaTLQUK+Cwr6IdBfgne3gZMsapkJgHPwed6/ko3ZCXjnD0MQw4UoOaDuIw== X-OriginatorOrg: infinera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2017 16:25:07.4582 (UTC) X-MS-Exchange-CrossTenant-Id: 285643de-5f5b-4b03-a153-0ae2dc8aaf77 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=285643de-5f5b-4b03-a153-0ae2dc8aaf77;Ip=[204.128.141.23];Helo=[owa.infinera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1551 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v1MGPZgW007521 On Wed, 2017-02-22 at 15:22 +0100, greg@kroah.com wrote: > On Wed, Feb 22, 2017 at 02:00:53PM +0000, Joakim Tjernlund wrote: > > On Wed, 2017-02-22 at 14:03 +0100, greg@kroah.com wrote: > > > On Wed, Feb 22, 2017 at 07:50:46AM +0000, Joakim Tjernlund wrote: > > > > On Wed, 2017-02-22 at 08:10 +0100, Greg KH wrote: > > > > > On Tue, Feb 21, 2017 at 04:24:04PM +0100, Joakim Tjernlund wrote: > > > > > > C++ does does not like the extra extern before asmlinkage, remove it. > > > > > > > > > > > > Signed-off-by: Joakim Tjernlund > > > > > > --- > > > > > > include/linux/printk.h | 4 ++-- > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/include/linux/printk.h b/include/linux/printk.h > > > > > > index 3472cc6..be823f5 100644 > > > > > > --- a/include/linux/printk.h > > > > > > +++ b/include/linux/printk.h > > > > > > > > > > > > > > > Why are you building this file with a C++ compiler? > > > > > > > > virtualbox uses C++ and includes various kernel headers and the build > > > > fails, virtualbox guest additions has not build for quite some time now and > > > > this is one of the problems. > > > > > > Virtualbox is a horrid pile of crap. You can quote me on that. We > > > don't care about out-of-tree drivers, the authors should work to get > > > them merged properly if they do care. > > > > Sure, I believe you :) > > > > But in this case it is not the kernel modules that fails, it is their > > guest additions/xf86 video driver. Seem like that these need to include some > > kernel herders there too. > > Seems like their build system is broken, it should not be including non > uapi header files at all. > > > > Kernel code should be C, not C++, and if you do want to use C++, then > > > you are on your own, sorry. > > > > But there are already a lot of C++ adjustments!? Just grepping for __cplusplus shows > > plenty of hits and what is the point of asmlinkage then: > > #ifdef __cplusplus > > #define CPP_ASMLINKAGE extern "C" > > #else > > #define CPP_ASMLINKAGE > > #endif > > > > #ifndef asmlinkage > > #define asmlinkage CPP_ASMLINKAGE > > #endif > > The usages in include/uapi/ make a bit of sense, but not much. > Everything outside of there makes no sense at all (really just some drm > and one scsi file.) They should be removed. > > > I read all of this that C++ code should be able to at least include kernel headers > > without fatal errors.  > > For uapi stuff, yes. But that's not what you are doing here. You are > trying to build kernel code with a c++ compiler. That's not going to > work. Right, I looked into guest-addition and it builds a few kernel modules too and include linux/string.h and that pulls in the offending code. Anyhow, the code in printk.h is "wrong" to add an extra extern so that change should not be a big deal as is, C++ or not. > > How is a C++ compiler supposed to parse the following line in device.h > struct class; > (one of my most proud moments...) :)