From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933190AbdBVSOq (ORCPT <rfc822;w@1wt.eu>);
        Wed, 22 Feb 2017 13:14:46 -0500
Received: from smtp.lesbg.com ([178.62.242.175]:46410 "EHLO smtp.lesbg.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933049AbdBVSOf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 22 Feb 2017 13:14:35 -0500
Message-ID: <1487787265.13719.10.camel@lesbg.com>
Subject: Re: [PATCH v2 1/2] usbip: Fix-format-overflow
From: Jonathan Dieter <jdieter@lesbg.com>
To: Krzysztof Opasiak <k.opasiak@samsung.com>,
        linux-kernel@vger.kernel.org
Cc: Valentina Manea <valentina.manea.m@gmail.com>,
        Shuah Khan <shuah@kernel.org>,
        Peter Senna Tschudin <peter.senna@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "open list:USB OVER IP DRIVER" <linux-usb@vger.kernel.org>
Date: Wed, 22 Feb 2017 20:14:25 +0200
In-Reply-To: <d129d7da-f98d-6bc5-399e-7432b75cd6ad@samsung.com>
References: <1487699421.13719.2.camel@lesbg.com>
         <CGME20170221175748epcas4p4f1fd0bfc11a0b8a65c2977085eec2255@epcas4p4.samsung.com>
         <20170221175713.18707-1-jdieter@lesbg.com>
         <d129d7da-f98d-6bc5-399e-7432b75cd6ad@samsung.com>
Organization: Lebanon Evangelical School for Boys and Girls
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.5 (3.22.5-1.fc25) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2017-02-22 at 06:49 +0100, Krzysztof Opasiak wrote:
> Hi,
> 
> W dniu 2017-02-21 o 18:57, Jonathan Dieter pisze:
<snip>
> >  	char busid[SYSFS_BUS_ID_SIZE];
> > +	unsigned int size;
> 
> I'm not really convinced to use unsigned here. snprintf() is declared
> to 
> return signed integer so we should assume that some of its 
> implementation may return negative error code. Any rationale to this 
> instead of just doing a cast for comparsion but signed value to print
> error?

No, you're absolutely right.  I've fixed this and am sending the next
revision now.

Jonathan