From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751296AbdBWSQ2 (ORCPT ); Thu, 23 Feb 2017 13:16:28 -0500 Received: from smtprelay0075.hostedemail.com ([216.40.44.75]:43154 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751156AbdBWSQ0 (ORCPT ); Thu, 23 Feb 2017 13:16:26 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3866:3867:3868:3870:3872:3874:4321:5007:7514:10004:10400:10471:10848:11026:11232:11473:11657:11658:11914:12043:12296:12438:12740:12760:12895:13069:13255:13311:13357:13439:14096:14097:14181:14659:14721:21080:21451:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: toy15_6e27f12235f32 X-Filterd-Recvd-Size: 2306 Message-ID: <1487873755.14159.43.camel@perches.com> Subject: Re: [PATCH] staging: vc04_services: Fixed "space prohibited after that open/close parenthesis" erros. From: Joe Perches To: Yamanappagouda Patil , gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org Date: Thu, 23 Feb 2017 10:15:55 -0800 In-Reply-To: <1487860253-6840-1-git-send-email-goudapatilk@gmail.com> References: <1487860253-6840-1-git-send-email-goudapatilk@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-02-23 at 20:00 +0530, Yamanappagouda Patil wrote: > Fixed checkpath.pl erros "space prohibited after that open/close parenthesis" in vchiq_version.c file. > > Signed-off-by: Yamanappagouda Patil > --- > .../vc04_services/interface/vchiq_arm/vchiq_version.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c [] > @@ -33,27 +33,27 @@ > #include "vchiq_build_info.h" > #include > > -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_hostname, "dc4-arm-01" ); > -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_version, "9245b4c35b99b3870e1f7dc598c5692b3c66a6f0 (tainted)" ); > -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_time, __TIME__ ); > -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_date, __DATE__ ); > +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_hostname, "dc4-arm-01"); > +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_version, "9245b4c35b99b3870e1f7dc598c5692b3c66a6f0 (tainted)"); > +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_time, __TIME__); > +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_date, __DATE__); Uses of __TIME__ and __DATE__ make it impossible to have repeatable builds. Are these __TIME__ and __DATE__ uses really useful and necessary?