From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751934AbdB0K2H convert rfc822-to-8bit (ORCPT ); Mon, 27 Feb 2017 05:28:07 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:59081 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751668AbdB0K2F (ORCPT ); Mon, 27 Feb 2017 05:28:05 -0500 Message-ID: <1488188908.2612.18.camel@pengutronix.de> Subject: Re: [PATCH v5] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver From: Jan =?ISO-8859-1?Q?L=FCbbe?= To: Richard Leitner , Rob Herring Cc: Linux USB List , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Greg Kroah-Hartman , Mark Rutland , Andy Shevchenko , dev@g0hl1n.net Date: Mon, 27 Feb 2017 10:48:28 +0100 In-Reply-To: References: <1486714767-25930-1-git-send-email-richard.leitner@skidata.com> <20170216023004.25dwzy7ppxdoasfz@rob-hp-laptop> <31fd459f-aed3-9d4a-2a63-651131216542@g0hl1n.net> Organization: Pengutronix Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c3 X-SA-Exim-Mail-From: jlu@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Di, 2017-02-21 at 15:57 +0100, Richard Leitner wrote: > >>> This is a lot of properties. Are you really finding a need for all of > >>> them? Is this to handle h/w designers too cheap to put down the EEPROM? > >>> Maybe better to just define an eeprom property in the format the h/w > >>> expects. > >> > >> > >> I need about 15 of these properties. I just exposed them all to dt because I > >> thought they could be useful for somebody. > >> > >> Yes, these are a subset of the settings which can be configured via an > >> external EEPROM (By strapping some pins of the hub you can select if it > >> loads its configuration from an EEPROM or receives it via SMBus). > >> > >> My first thought was also to define only a byte array in dt, but IMHO these > >> options are much more readable and convenient for everybody. I'd also be > >> fine with removing the properties I don't need from dt. But that may lead to > >> future patches where somebody needs some of the options not already exposed > >> to dt. > > > > Okay. It's really a judgement call. If this is most of the settings, > > then it's fine. If it was only a fraction of them, then maybe we'd > > want to do just a byte array. Sounds like it is the former. > > In fact there are 6 more parameters available according to the > datasheet. So how should I proceed here? Remove the one's I'm not using > at the moment, leave them as they are or add the missing 6 too? Rob, several of these properties look more like configuration rather than HW description ('skip-config', '*-id', 'manufacturer', 'product', 'serial'). Is DT the right place for this? I would expect userspace to provide the configuration. Regards, Jan -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |