From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752421AbdB1Ocg (ORCPT ); Tue, 28 Feb 2017 09:32:36 -0500 Received: from mga02.intel.com ([134.134.136.20]:14398 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752117AbdB1Occ (ORCPT ); Tue, 28 Feb 2017 09:32:32 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,219,1484035200"; d="scan'208";a="829335067" Message-ID: <1488292131.20145.61.camel@linux.intel.com> Subject: Re: [PATCH 0/3] lib: add module support to sort tests From: Andy Shevchenko To: Geert Uytterhoeven , Andrew Morton Cc: Arnd Bergmann , Paul Gortmaker , Shuah Khan , linux-kernel@vger.kernel.org Date: Tue, 28 Feb 2017 16:28:51 +0200 In-Reply-To: <1488287219-15832-1-git-send-email-geert@linux-m68k.org> References: <1488287219-15832-1-git-send-email-geert@linux-m68k.org> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-02-28 at 14:06 +0100, Geert Uytterhoeven wrote: > Hi Andrew, > > This patch series allows to compile the array-based and linked list > sort > test code either to loadable modules, or builtin into the kernel. > > It's very valuable to have modular tests, so you can run them just by > insmodding the test modules, instead of needing a separate kernel that > runs them at boot. > > Thanks for applying! FWIW: Reviewed-by: Andy Shevchenko On the first glance looks okay to me. I didn't carefully checked code move (I guess -M -C will not help much, though one can play with numbers there), so I believe Geert didn't change much there. > > Geert Uytterhoeven (3): >   Revert "lib/test_sort.c: make it explicitly non-modular" >   lib: add module support to array-based sort tests >   lib: add module support to linked list sorting tests > >  lib/Kconfig.debug    |  14 ++--- >  lib/Makefile         |   1 + >  lib/list_sort.c      | 149 ------------------------------------------ > -------- >  lib/test_list_sort.c | 150 > +++++++++++++++++++++++++++++++++++++++++++++++++++ >  lib/test_sort.c      |  11 ++-- >  5 files changed, 164 insertions(+), 161 deletions(-) >  create mode 100644 lib/test_list_sort.c > -- Andy Shevchenko Intel Finland Oy