From: Elena Reshetova <elena.reshetova@intel.com>
To: linux-kernel@vger.kernel.org
Cc: linux-xfs@vger.kernel.org, peterz@infradead.org,
gregkh@linuxfoundation.org, darrick.wong@oracle.com,
david@fromorbit.com, Elena Reshetova <elena.reshetova@intel.com>
Subject: [PATCH 0/5] fs, xfs atomic_t to refcount_t conversions version 2
Date: Wed, 1 Mar 2017 10:47:35 +0200 [thread overview]
Message-ID: <1488358060-693-1-git-send-email-elena.reshetova@intel.com> (raw)
changes in v2:
* removed two patches that actually caused problems in testing and
there didn't seem to be a resonable way to convert them to refcount_t
based on all the triggered issues.
* run xfstests with TEST and SCRATCH partitions enabled, XFS_DEBUG on,
and WARNs on refcount_t API on. No issues found in the log upon execution.
Some random test failures (based on different runs) and stress tests do not always
pass, but again, no issues on refcounts noticed anywhere.
Now when new refcount_t type and API are finally merged
(see include/linux/refcount.h), the following
patches convert various refcounters in the fs/xfs susystem from atomic_t
to refcount_t. By doing this we prevent intentional or accidental
underflows or overflows that can led to use-after-free vulnerabilities.
The below patches are fully independent and can be cherry-picked separately.
Since we convert all kernel subsystems in the same fashion, resulting
in about 300 patches, we have to group them for sending at least in some
fashion to be manageable. Please excuse the long cc list.
Elena Reshetova (5):
fs, xfs: convert xfs_bui_log_item.bui_refcount from atomic_t to
refcount_t
fs, xfs: convert xfs_efi_log_item.efi_refcount from atomic_t to
refcount_t
fs, xfs: convert xlog_ticket.t_ref from atomic_t to refcount_t
fs, xfs: convert xfs_cui_log_item.cui_refcount from atomic_t to
refcount_t
fs, xfs: convert xfs_rui_log_item.rui_refcount from atomic_t to
refcount_t
fs/xfs/xfs_bmap_item.c | 4 ++--
fs/xfs/xfs_bmap_item.h | 4 +++-
fs/xfs/xfs_extfree_item.c | 4 ++--
fs/xfs/xfs_extfree_item.h | 4 +++-
fs/xfs/xfs_log.c | 10 +++++-----
fs/xfs/xfs_log_priv.h | 4 +++-
fs/xfs/xfs_refcount_item.c | 4 ++--
fs/xfs/xfs_refcount_item.h | 4 +++-
fs/xfs/xfs_rmap_item.c | 4 ++--
fs/xfs/xfs_rmap_item.h | 4 +++-
10 files changed, 28 insertions(+), 18 deletions(-)
--
2.7.4
next reply other threads:[~2017-03-01 13:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 8:47 Elena Reshetova [this message]
2017-03-01 8:47 ` [PATCH 1/5] fs, xfs: convert xfs_bui_log_item.bui_refcount from atomic_t to refcount_t Elena Reshetova
2017-03-01 8:47 ` [PATCH 2/5] fs, xfs: convert xfs_efi_log_item.efi_refcount " Elena Reshetova
2017-03-01 8:47 ` [PATCH 3/5] fs, xfs: convert xlog_ticket.t_ref " Elena Reshetova
2017-03-01 8:47 ` [PATCH 4/5] fs, xfs: convert xfs_cui_log_item.cui_refcount " Elena Reshetova
2017-03-06 19:14 ` Darrick J. Wong
2017-03-07 17:33 ` Reshetova, Elena
2017-03-07 20:30 ` Darrick J. Wong
2017-03-01 8:47 ` [PATCH 5/5] fs, xfs: convert xfs_rui_log_item.rui_refcount " Elena Reshetova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488358060-693-1-git-send-email-elena.reshetova@intel.com \
--to=elena.reshetova@intel.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).