linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kernel-team@lge.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.com>, Minchan Kim <minchan@kernel.org>,
	"Kirill A . Shutemov" <kirill@shutemov.name>
Subject: [RFC 01/11] mm: use SWAP_SUCCESS instead of 0
Date: Thu,  2 Mar 2017 15:39:15 +0900	[thread overview]
Message-ID: <1488436765-32350-2-git-send-email-minchan@kernel.org> (raw)
In-Reply-To: <1488436765-32350-1-git-send-email-minchan@kernel.org>

SWAP_SUCCESS defined value 0 can be changed always so don't rely on
it. Instead, use explict macro.

Cc: Kirill A. Shutemov <kirill@shutemov.name>
Signed-off-by: Minchan Kim <minchan@kernel.org>
---
 mm/huge_memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 092cc5c..fe2ccd4 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -2114,7 +2114,7 @@ static void freeze_page(struct page *page)
 		ttu_flags |= TTU_MIGRATION;
 
 	ret = try_to_unmap(page, ttu_flags);
-	VM_BUG_ON_PAGE(ret, page);
+	VM_BUG_ON_PAGE(ret != SWAP_SUCCESS, page);
 }
 
 static void unfreeze_page(struct page *page)
-- 
2.7.4

  reply	other threads:[~2017-03-02  7:10 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02  6:39 [RFC 00/11] make try_to_unmap simple Minchan Kim
2017-03-02  6:39 ` Minchan Kim [this message]
2017-03-02 14:27   ` [RFC 01/11] mm: use SWAP_SUCCESS instead of 0 Anshuman Khandual
2017-03-03  3:01     ` Minchan Kim
2017-03-06  9:07       ` Anshuman Khandual
2017-03-07 14:19   ` Kirill A. Shutemov
2017-03-08  6:25     ` Minchan Kim
2017-03-02  6:39 ` [RFC 02/11] mm: remove unncessary ret in page_referenced Minchan Kim
2017-03-02 14:33   ` Anshuman Khandual
2017-03-03  3:03     ` Minchan Kim
2017-03-07 14:20   ` Kirill A. Shutemov
2017-03-02  6:39 ` [RFC 03/11] mm: remove SWAP_DIRTY in ttu Minchan Kim
2017-03-02  7:34   ` Hillf Danton
2017-03-03  2:57     ` Minchan Kim
2017-03-02 14:42   ` Anshuman Khandual
2017-03-07 14:20   ` Kirill A. Shutemov
2017-03-02  6:39 ` [RFC 04/11] mm: remove SWAP_MLOCK check for SWAP_SUCCESS " Minchan Kim
2017-03-02 14:51   ` Anshuman Khandual
2017-03-03  3:04     ` Minchan Kim
2017-03-07 14:26   ` Kirill A. Shutemov
2017-03-08  6:40     ` Minchan Kim
2017-03-02  6:39 ` [RFC 05/11] mm: make the try_to_munlock void function Minchan Kim
2017-03-03 11:43   ` Anshuman Khandual
2017-03-06  2:09     ` Minchan Kim
2017-03-06  9:40       ` Anshuman Khandual
2017-03-07  6:50         ` Minchan Kim
2017-03-07  8:55           ` Anshuman Khandual
2017-03-07 15:17   ` Kirill A. Shutemov
2017-03-08  6:41     ` Minchan Kim
2017-03-02  6:39 ` [RFC 06/11] mm: remove SWAP_MLOCK in ttu Minchan Kim
2017-03-03 12:36   ` Anshuman Khandual
2017-03-06  2:15     ` Minchan Kim
2017-03-07 15:24       ` Kirill A. Shutemov
2017-03-08  6:42         ` Minchan Kim
2017-03-02  6:39 ` [RFC 07/11] mm: remove SWAP_AGAIN " Minchan Kim
2017-03-03 12:54   ` Anshuman Khandual
2017-03-06  2:16     ` Minchan Kim
2017-03-02  6:39 ` [RFC 08/11] mm: make ttu's return boolean Minchan Kim
2017-03-08  7:13   ` John Hubbard
2017-03-09  6:37     ` Minchan Kim
2017-03-09  6:46       ` John Hubbard
2017-03-02  6:39 ` [RFC 09/11] mm: make rmap_walk void function Minchan Kim
2017-03-02  6:39 ` [RFC 10/11] mm: make rmap_one boolean function Minchan Kim
2017-03-02  6:39 ` [RFC 11/11] mm: remove SWAP_[SUCCESS|AGAIN|FAIL] Minchan Kim
2017-03-03 13:04   ` Anshuman Khandual
2017-03-06  2:18     ` Minchan Kim
2017-03-02 14:22 ` [RFC 00/11] make try_to_unmap simple Anshuman Khandual
2017-03-03  2:11   ` Minchan Kim
2017-03-03  5:39     ` Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488436765-32350-2-git-send-email-minchan@kernel.org \
    --to=minchan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@lge.com \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).