From: Joe Perches <joe@perches.com>
To: SIMRAN SINGHAL <singhalsimran0@gmail.com>
Cc: Larry.Finger@lwfinger.net,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg KH <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
oleg.drokin@intel.com, marvin24@gmx.de,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer
Date: Thu, 02 Mar 2017 14:09:52 -0800 [thread overview]
Message-ID: <1488492592.2179.20.camel@perches.com> (raw)
In-Reply-To: <CALrZqyP6S2mwYUBERerLnG99qVSFm5jHppjy695JARHMfZ-5Pw@mail.gmail.com>
On Fri, 2017-03-03 at 03:35 +0530, SIMRAN SINGHAL wrote:
> On Fri, Mar 3, 2017 at 3:29 AM, Joe Perches <joe@perches.com> wrote:
> > On Fri, 2017-03-03 at 03:25 +0530, SIMRAN SINGHAL wrote:
> > > On Fri, Mar 3, 2017 at 3:13 AM, Joe Perches <joe@perches.com> wrote:
> > > > On Fri, 2017-03-03 at 02:49 +0530, simran singhal wrote:
> > > > > The following Coccinelle script was used to detect this:
> > > > > @r@
> > > > > expression x;
> > > > > void* e;
> > > > > type T;
> > > > > identifier f;
> > > > > @@
> > > > > (
> > > > > *((T *)e)
> > > > > >
> > > > >
> > > > > ((T *)x)[...]
> > > > > >
> > > > >
> > > > > ((T*)x)->f
> > > > > >
> > > > >
> > > > > - (T*)
> > > > > e
> > > > > )
> > > >
> > > > NAK.
> > > >
> > > > Nice, but you still have to verify correctness
> > > > before submitting these patches.
> > > >
> > > > > diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c
> > > >
> > > > []
> > > > > @@ -1034,7 +1034,7 @@ static int mgc_set_info_async(const struct lu_env *env, struct obd_export *exp,
> > > > > rc = sptlrpc_parse_flavor(val, &flvr);
> > > > > if (rc) {
> > > > > CERROR("invalid sptlrpc flavor %s to MGS\n",
> > > > > - (char *)val);
> > > > > + val);
> > > >
> > > > Try compiling this.
> > > >
> > >
> > > I compiled it before sending.
> >
> > Did you look at the warnings?
> >
> > CC [M] drivers/staging/lustre/lustre/mgc/mgc_request.o
> > drivers/staging/lustre/lustre/mgc/mgc_request.c: In function ‘mgc_set_info_async’:
> > drivers/staging/lustre/lustre/mgc/mgc_request.c:1036:115: warning: format ‘%s’ expects argument of type ‘char *’, but argument 3 has type ‘void *’ [-Wformat=]
> > CERROR("invalid sptlrpc flavor %s to MGS\n",
> >
>
> I again compiled it and this is what I got :-
>
> CHK include/config/kernel.release
> CHK include/generated/uapi/linux/version.h
> CHK include/generated/utsrelease.h
> CHK include/generated/timeconst.h
> CHK include/generated/bounds.h
> CHK include/generated/asm-offsets.h
> CALL scripts/checksyscalls.sh
> CHK include/generated/compile.h
> LD arch/x86/boot/compressed/vmlinux
> ZOFFSET arch/x86/boot/zoffset.h
> AS arch/x86/boot/header.o
> LD arch/x86/boot/setup.elf
> OBJCOPY arch/x86/boot/setup.bin
> OBJCOPY arch/x86/boot/vmlinux.bin
> BUILD arch/x86/boot/bzImage
> Setup is 17500 bytes (padded to 17920 bytes).
> System is 7128 kB
> CRC 37713343
> Kernel: arch/x86/boot/bzImage is ready (#4)
> Building modules, stage 2.
> MODPOST 4541 modules
>
> I am not getting any warning.
Then you are likely not compiling the modified file.
try:
$ <git checkout latest-next>
$ make clean
$ make allyesconfig
<apply your patch>
$ make drivers/staging/lustre/lustre/mgc/mgc_request.o
next prev parent reply other threads:[~2017-03-02 22:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 21:19 [PATCH 1/5] staging: nvec: Remove unnecessary cast on void pointer simran singhal
2017-03-02 21:19 ` [PATCH 2/5] staging: lustre: " simran singhal
2017-03-02 21:19 ` [PATCH 3/5] staging: lustre: " simran singhal
2017-03-02 21:43 ` Joe Perches
2017-03-02 21:55 ` SIMRAN SINGHAL
2017-03-02 21:59 ` Joe Perches
2017-03-02 22:05 ` SIMRAN SINGHAL
2017-03-02 22:07 ` [Outreachy kernel] " Julia Lawall
2017-03-02 22:09 ` Joe Perches [this message]
2017-03-03 22:41 ` kbuild test robot
2017-03-04 0:16 ` kbuild test robot
2017-03-02 21:19 ` [PATCH 4/5] staging: rts5208: " simran singhal
2017-03-02 21:56 ` [Outreachy kernel] " Julia Lawall
2017-03-02 21:58 ` SIMRAN SINGHAL
2017-03-02 21:19 ` [PATCH 5/5] staging: rtl8712: " simran singhal
2017-03-02 21:56 ` [Outreachy kernel] " Julia Lawall
2017-03-02 21:57 ` SIMRAN SINGHAL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488492592.2179.20.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=oleg.drokin@intel.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=singhalsimran0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).