From: Joe Perches <joe@perches.com>
To: SIMRAN SINGHAL <singhalsimran0@gmail.com>
Cc: Larry.Finger@lwfinger.net,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg KH <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
oleg.drokin@intel.com, marvin24@gmx.de,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v3 0/5] Fixed compilation error
Date: Fri, 03 Mar 2017 12:13:33 -0800 [thread overview]
Message-ID: <1488572013.2179.34.camel@perches.com> (raw)
In-Reply-To: <CALrZqyMKJvhQMAdjtLWWKTtxOP+icRZ6bctB0bTtzA8gJi+wNA@mail.gmail.com>
On Fri, 2017-03-03 at 21:35 +0530, SIMRAN SINGHAL wrote:
> On Fri, Mar 3, 2017 at 9:20 PM, Joe Perches <joe@perches.com> wrote:
> > On Fri, 2017-03-03 at 17:05 +0530, simran singhal wrote:
> > > Fixed compilation warning in lustre/lustre/llite/range_lock.c
> >
> > Really? What compilation warning was removed?
>
> CC [M] drivers/staging/lustre/lustre/mgc/mgc_request.o
> drivers/staging/lustre/lustre/mgc/mgc_request.c: In function
> ‘mgc_set_info_async’:
> drivers/staging/lustre/lustre/mgc/mgc_request.c:1036:115: warning:
> format ‘%s’ expects argument of type ‘char *’, but argument 3 has type
> ‘void *’ [-Wformat=]
>
> I was getting this warning because of changing (char *)val to val
> where val is a pointer to void.
> So I fixed this by reverting this change.
Wrong thought.
Your original defective patches were not applied and
this is a simple revision to those defective patches
that do not include defects.
As Julia has said, you should use the imperative and
describe the change that this patch series implements.
i.e:
Subject: [PATCH V3 0/5] staging: Remove unnecessary casts
Casting void pointers to another undereferenced type is
generally unnecessary so remove the unnecessary casts.
prev parent reply other threads:[~2017-03-03 20:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 11:35 [PATCH v3 0/5] Fixed compilation error simran singhal
2017-03-03 11:35 ` [PATCH v3 1/5] staging: nvec: Remove unnecessary cast on void pointer simran singhal
2017-03-03 11:35 ` [PATCH v3 2/5] staging: lustre: " simran singhal
2017-03-03 11:35 ` [PATCH v3 3/5] staging: lustre: " simran singhal
2017-03-03 11:35 ` [PATCH v3 4/5] staging: rts5208: " simran singhal
2017-03-03 11:35 ` [PATCH v3 5/5] staging: rtl8712: " simran singhal
2017-03-03 15:50 ` [PATCH v3 0/5] Fixed compilation error Joe Perches
2017-03-03 16:05 ` SIMRAN SINGHAL
2017-03-03 16:15 ` [Outreachy kernel] " Julia Lawall
2017-03-03 16:37 ` SIMRAN SINGHAL
2017-03-03 20:13 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488572013.2179.34.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=oleg.drokin@intel.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=singhalsimran0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).