From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: <lee.jones@linaro.org>
Cc: <linux-kernel@vger.kernel.org>, <patches@opensource.wolfsonmicro.com>
Subject: [PATCH RESEND 2/4] mfd: arizona: Display register addresses in hex
Date: Thu, 9 Mar 2017 09:28:33 +0000 [thread overview]
Message-ID: <1489051715-4774-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1489051715-4774-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
Register addresses are normally displayed in hex throughout the Arizona
driver. Update the arizona_poll_reg function to follow this convention.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
drivers/mfd/arizona-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index e00f577..4cb34c3 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -245,7 +245,7 @@ static int arizona_poll_reg(struct arizona *arizona,
for (i = 0; i < timeout; i++) {
ret = regmap_read(arizona->regmap, reg, &val);
if (ret != 0) {
- dev_err(arizona->dev, "Failed to read reg %u: %d\n",
+ dev_err(arizona->dev, "Failed to read reg 0x%x: %d\n",
reg, ret);
continue;
}
@@ -256,7 +256,7 @@ static int arizona_poll_reg(struct arizona *arizona,
usleep_range(1000, 5000);
}
- dev_err(arizona->dev, "Polling reg %u timed out: %x\n", reg, val);
+ dev_err(arizona->dev, "Polling reg 0x%x timed out: %x\n", reg, val);
return -ETIMEDOUT;
}
--
2.1.4
next prev parent reply other threads:[~2017-03-09 9:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 9:28 [PATCH RESEND 1/4] mfd: arizona: Remove duplicate set of ret variable Charles Keepax
2017-03-09 9:28 ` Charles Keepax [this message]
2017-03-14 17:06 ` [PATCH RESEND 2/4] mfd: arizona: Display register addresses in hex Lee Jones
2017-03-09 9:28 ` [PATCH RESEND 3/4] mfd: arizona: Update arizona_poll_reg to take a timeout in milliseconds Charles Keepax
2017-03-14 17:06 ` Lee Jones
2017-03-09 9:28 ` [PATCH RESEND 4/4] mfd: arizona: Use regmap_read_poll_timeout instead of hard coding it Charles Keepax
2017-03-14 17:07 ` Lee Jones
2017-03-14 18:44 ` Charles Keepax
2017-03-15 12:17 ` Lee Jones
2017-03-15 14:40 ` Charles Keepax
2017-03-14 17:06 ` [PATCH RESEND 1/4] mfd: arizona: Remove duplicate set of ret variable Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2017-01-31 14:44 Charles Keepax
2017-01-31 14:44 ` [PATCH RESEND 2/4] mfd: arizona: Display register addresses in hex Charles Keepax
2017-02-08 10:20 ` Lee Jones
2017-02-08 11:20 ` Charles Keepax
2017-02-08 12:50 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489051715-4774-2-git-send-email-ckeepax@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).