From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752711AbdCNRSC (ORCPT ); Tue, 14 Mar 2017 13:18:02 -0400 Received: from smtprelay0014.hostedemail.com ([216.40.44.14]:44282 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751035AbdCNRSB (ORCPT ); Tue, 14 Mar 2017 13:18:01 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2731:2828:2899:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3874:4321:5007:9389:10004:10400:10848:11232:11473:11658:11914:12043:12296:12438:12740:12760:12895:13069:13200:13229:13311:13357:13439:14181:14659:14721:21080:21433:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: sleep42_7f31361e3284d X-Filterd-Recvd-Size: 1964 Message-ID: <1489511868.2582.2.camel@perches.com> Subject: Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn From: Joe Perches To: Lee Jones Cc: Linus Walleij , Tony Lindgren , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Date: Tue, 14 Mar 2017 10:17:48 -0700 In-Reply-To: <20170314140455.umlhdbuj3grqtu6i@dell> References: <20170314140455.umlhdbuj3grqtu6i@dell> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-03-14 at 14:04 +0000, Lee Jones wrote: > On Thu, 16 Feb 2017, Joe Perches wrote: > > To enable eventual removal of pr_warning [] > > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c [] > > @@ -502,9 +502,7 @@ static int load_twl4030_script(const struct twl4030_power_data *pdata, > > } > > if (tscript->flags & TWL4030_SLEEP_SCRIPT) { > > if (!order) > > - pr_warning("TWL4030: Bad order of scripts (sleep "\ > > - "script before wakeup) Leads to boot"\ > > - "failure on some boards\n"); > > + pr_warn("TWL4030: Bad order of scripts (sleep script before wakeup) Leads to boot failure on some boards\n"); > > Is 80 chars considered the lessor sin? Splitting logging messages into multiple lines is non preferred. Documentation/process/coding-style.rst: Breaking long lines and strings: never break user-visible strings such as printk messages, because that breaks the ability to grep for them.