From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753916AbdCOOTR (ORCPT ); Wed, 15 Mar 2017 10:19:17 -0400 Received: from smtprelay0199.hostedemail.com ([216.40.44.199]:39199 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751458AbdCOORf (ORCPT ); Wed, 15 Mar 2017 10:17:35 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:7903:10004:10400:10848:11232:11658:11914:12663:12740:12760:12895:13069:13095:13161:13181:13229:13311:13357:13439:14659:14721:21080:21433:30041:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: dirt51_414bcddab8701 X-Filterd-Recvd-Size: 1851 Message-ID: <1489587444.2582.6.camel@perches.com> Subject: Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn From: Joe Perches To: Lee Jones Cc: Linus Walleij , Tony Lindgren , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Date: Wed, 15 Mar 2017 07:17:24 -0700 In-Reply-To: <20170315122300.jwuogngm6obgvz5z@dell> References: <20170314140455.umlhdbuj3grqtu6i@dell> <1489511868.2582.2.camel@perches.com> <20170315122300.jwuogngm6obgvz5z@dell> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-03-15 at 12:23 +0000, Lee Jones wrote: > On Tue, 14 Mar 2017, Joe Perches wrote: [] > > never break user-visible strings such as > > printk messages, because that breaks the ability to grep for them. > > Right, I'm aware of this. I'm also aware of the other rule we have > where lines are not to exceed 80 chars. Hence my question; "is the 80 > chars rule the lessor sin of the two". > > Rock <=> hard place > > Actually I would say that the error message sub-optimal and could, in > fact be edited to be more succinct, thus not breaking any rules. It's not a 'sin' at all. The rule is to exceed 80 columns when the logging message format is long. I didn't even look at the format content. Change it if you wish.