From: Jonathan Dieter <jdieter@lesbg.com>
To: linux-kernel@vger.kernel.org
Cc: Valentina Manea <valentina.manea.m@gmail.com>,
Shuah Khan <shuah@kernel.org>,
Peter Senna Tschudin <peter.senna@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Opasiak <k.opasiak@samsung.com>,
"open list:USB OVER IP DRIVER" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] usbip: Fix-format-overflow
Date: Thu, 16 Mar 2017 09:47:59 +0200 [thread overview]
Message-ID: <1489650479.2097.9.camel@lesbg.com> (raw)
In-Reply-To: <20170227083108.16391-1-jdieter@lesbg.com>
On Mon, 2017-02-27 at 10:31 +0200, Jonathan Dieter wrote:
> The usbip userspace tools call sprintf()/snprintf() and don't check for
> the return value which can lead the paths to overflow, truncating the
> final file in the path.
>
> More urgently, GCC 7 now warns that these aren't checked with
> -Wformat-overflow, and with -Werror enabled in configure.ac, that makes
> these tools unbuildable.
>
> This patch fixes these problems by replacing sprintf() with snprintf() in
> one place and adding checks for the return value of snprintf().
>
> > Reviewed-by: Peter Senna Tschudin <peter.senna@gmail.com>
> > Signed-off-by: Jonathan Dieter <jdieter@lesbg.com>
> ---
> Changes since v3
> * Cast sizeof to long unsigned when printing errors to fix building for 32-bit
> architectures
Just wanted to check if there's anything else I need to do to make this
ready?
Thanks,
Jonathan
next prev parent reply other threads:[~2017-03-16 7:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170220205937epcas3p4e334a658cf4d67f4a7d5a4ae7ce10afc@epcas3p4.samsung.com>
2017-02-20 20:51 ` [PATCH 1/2] Fix format overflows Jonathan Dieter
2017-02-20 20:51 ` [PATCH 2/2] Fix implicit fallthrough warning Jonathan Dieter
2017-02-21 6:12 ` [PATCH 1/2] Fix format overflows Krzysztof Opasiak
2017-02-21 6:48 ` Jonathan Dieter
2017-02-21 17:50 ` Jonathan Dieter
2017-02-21 17:57 ` [PATCH v2 1/2] usbip: Fix-format-overflow Jonathan Dieter
2017-02-21 17:57 ` [PATCH v2 2/2] usbip: Fix implicit fallthrough warning Jonathan Dieter
2017-02-22 5:49 ` [PATCH v2 1/2] usbip: Fix-format-overflow Krzysztof Opasiak
2017-02-22 18:14 ` Jonathan Dieter
2017-02-22 18:17 ` [PATCH v3 " Jonathan Dieter
2017-02-22 18:18 ` [PATCH v3 2/2] usbip: Fix implicit fallthrough warning Jonathan Dieter
2017-02-27 8:31 ` [PATCH v4 1/2] usbip: Fix-format-overflow Jonathan Dieter
2017-02-27 8:31 ` [PATCH v4 2/2] usbip: Fix implicit fallthrough warning Jonathan Dieter
2017-03-16 7:47 ` Jonathan Dieter [this message]
2017-03-16 15:04 ` [PATCH v4 1/2] usbip: Fix-format-overflow Shuah Khan
2017-03-17 1:37 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489650479.2097.9.camel@lesbg.com \
--to=jdieter@lesbg.com \
--cc=gregkh@linuxfoundation.org \
--cc=k.opasiak@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).