From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: Sergey Senozhatsky <senozhatsky@chromium.org>,
Tomasz Figa <tfiga@chromium.org>
Cc: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
Ricardo Ribalda <ribalda@chromium.org>,
Christoph Hellwig <hch@lst.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv4 3/8] videobuf2: split buffer cache_hints initialisation
Date: Tue, 3 Aug 2021 10:10:19 +0200 [thread overview]
Message-ID: <148b9d78-7515-eb1d-7e38-f8e1052d057c@xs4all.nl> (raw)
In-Reply-To: <20210727070517.443167-4-senozhatsky@chromium.org>
On 27/07/2021 09:05, Sergey Senozhatsky wrote:
> V4L2 is not the perfect place to manage vb2 buffer cache hints.
> It works for V4L2 users, but there are backends that use vb2 core
use -> use the
> and don't use V4L2. Factor buffer cache hints init and call it
Factor? You mean Refactor?
Regards,
Hans
> when we allocate vb2 buffer.
>
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
> ---
> .../media/common/videobuf2/videobuf2-core.c | 22 +++++++++++++++++++
> .../media/common/videobuf2/videobuf2-v4l2.c | 18 ---------------
> 2 files changed, 22 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
> index 23e41fec9880..76210c006958 100644
> --- a/drivers/media/common/videobuf2/videobuf2-core.c
> +++ b/drivers/media/common/videobuf2/videobuf2-core.c
> @@ -382,6 +382,27 @@ static void __setup_offsets(struct vb2_buffer *vb)
> }
> }
>
> +static void init_buffer_cache_hints(struct vb2_queue *q, struct vb2_buffer *vb)
> +{
> + /*
> + * DMA exporter should take care of cache syncs, so we can avoid
> + * explicit ->prepare()/->finish() syncs. For other ->memory types
> + * we always need ->prepare() or/and ->finish() cache sync.
> + */
> + if (q->memory == VB2_MEMORY_DMABUF) {
> + vb->skip_cache_sync_on_finish = 1;
> + vb->skip_cache_sync_on_prepare = 1;
> + return;
> + }
> +
> + /*
> + * ->finish() cache sync can be avoided when queue direction is
> + * TO_DEVICE.
> + */
> + if (q->dma_dir == DMA_TO_DEVICE)
> + vb->skip_cache_sync_on_finish = 1;
> +}
> +
> /*
> * __vb2_queue_alloc() - allocate videobuf buffer structures and (for MMAP type)
> * video buffer memory for all buffers/planes on the queue and initializes the
> @@ -415,6 +436,7 @@ static int __vb2_queue_alloc(struct vb2_queue *q, enum vb2_memory memory,
> vb->index = q->num_buffers + buffer;
> vb->type = q->type;
> vb->memory = memory;
> + init_buffer_cache_hints(q, vb);
> for (plane = 0; plane < num_planes; ++plane) {
> vb->planes[plane].length = plane_sizes[plane];
> vb->planes[plane].min_length = plane_sizes[plane];
> diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2.c b/drivers/media/common/videobuf2/videobuf2-v4l2.c
> index 454d58268602..2fbae9bd7b52 100644
> --- a/drivers/media/common/videobuf2/videobuf2-v4l2.c
> +++ b/drivers/media/common/videobuf2/videobuf2-v4l2.c
> @@ -345,17 +345,6 @@ static void set_buffer_cache_hints(struct vb2_queue *q,
> struct vb2_buffer *vb,
> struct v4l2_buffer *b)
> {
> - /*
> - * DMA exporter should take care of cache syncs, so we can avoid
> - * explicit ->prepare()/->finish() syncs. For other ->memory types
> - * we always need ->prepare() or/and ->finish() cache sync.
> - */
> - if (q->memory == VB2_MEMORY_DMABUF) {
> - vb->skip_cache_sync_on_finish = 1;
> - vb->skip_cache_sync_on_prepare = 1;
> - return;
> - }
> -
> if (!vb2_queue_allows_cache_hints(q)) {
> /*
> * Clear buffer cache flags if queue does not support user
> @@ -367,13 +356,6 @@ static void set_buffer_cache_hints(struct vb2_queue *q,
> return;
> }
>
> - /*
> - * ->finish() cache sync can be avoided when queue direction is
> - * TO_DEVICE.
> - */
> - if (q->dma_dir == DMA_TO_DEVICE)
> - vb->skip_cache_sync_on_finish = 1;
> -
> if (b->flags & V4L2_BUF_FLAG_NO_CACHE_INVALIDATE)
> vb->skip_cache_sync_on_finish = 1;
>
>
next prev parent reply other threads:[~2021-08-03 8:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 7:05 [PATCHv4 0/8] videobuf2: support new noncontiguous DMA API Sergey Senozhatsky
2021-07-27 7:05 ` [PATCHv4 1/8] videobuf2: rework vb2_mem_ops API Sergey Senozhatsky
2021-08-03 8:08 ` Hans Verkuil
2021-08-17 10:41 ` Sergey Senozhatsky
2021-07-27 7:05 ` [PATCHv4 2/8] videobuf2: inverse buffer cache_hints flags Sergey Senozhatsky
2021-07-27 7:05 ` [PATCHv4 3/8] videobuf2: split buffer cache_hints initialisation Sergey Senozhatsky
2021-08-03 8:10 ` Hans Verkuil [this message]
2021-08-17 10:41 ` Sergey Senozhatsky
2021-07-27 7:05 ` [PATCHv4 4/8] videobuf2: move cache_hints handling to allocators Sergey Senozhatsky
2021-08-03 8:11 ` Hans Verkuil
2021-08-17 10:42 ` Sergey Senozhatsky
2021-07-27 7:05 ` [PATCHv4 5/8] videobuf2: add V4L2_MEMORY_FLAG_NON_COHERENT flag Sergey Senozhatsky
2021-08-03 8:12 ` Hans Verkuil
2021-08-17 10:42 ` Sergey Senozhatsky
2021-07-27 7:05 ` [PATCHv4 6/8] videobuf2: add queue memory coherency parameter Sergey Senozhatsky
2021-08-03 8:29 ` Hans Verkuil
2021-08-17 10:43 ` Sergey Senozhatsky
2021-07-27 7:05 ` [PATCHv4 7/8] videobuf2: handle V4L2_MEMORY_FLAG_NON_COHERENT flag Sergey Senozhatsky
2021-08-03 8:31 ` Hans Verkuil
2021-08-17 10:43 ` Sergey Senozhatsky
2021-07-27 7:05 ` [PATCHv4 8/8] videobuf2: handle non-contiguous DMA allocations Sergey Senozhatsky
2021-08-03 8:33 ` Hans Verkuil
2021-08-03 8:39 ` Hans Verkuil
2021-08-23 10:28 ` Sergey Senozhatsky
2021-08-23 10:27 ` Sergey Senozhatsky
2021-08-03 10:15 ` Hans Verkuil
2021-08-17 11:56 ` Sergey Senozhatsky
2021-08-18 9:20 ` Tomasz Figa
2021-08-23 10:29 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=148b9d78-7515-eb1d-7e38-f8e1052d057c@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=dafna.hirschfeld@collabora.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
--cc=senozhatsky@chromium.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).