From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758846AbdCVGaF (ORCPT ); Wed, 22 Mar 2017 02:30:05 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:4352 "EHLO dggrg02-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1758611AbdCVG33 (ORCPT ); Wed, 22 Mar 2017 02:29:29 -0400 From: Zhen Lei To: Joerg Roedel , iommu , Robin Murphy , David Woodhouse , Sudeep Dutt , Ashutosh Dixit , linux-kernel CC: Zefan Li , Xinwei Hu , "Tianhong Ding" , Hanjun Guo , Zhen Lei Subject: [PATCH 1/7] iommu/iova: fix incorrect variable types Date: Wed, 22 Mar 2017 14:27:41 +0800 Message-ID: <1490164067-12552-2-git-send-email-thunder.leizhen@huawei.com> X-Mailer: git-send-email 1.9.5.msysgit.0 In-Reply-To: <1490164067-12552-1-git-send-email-thunder.leizhen@huawei.com> References: <1490164067-12552-1-git-send-email-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.177.23.164] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A0B0202.58D219C3.039A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 78cbb16d2aeef7ce94a35e29d941e132 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Keep these four variables type consistent with the paramters of function __alloc_and_insert_iova_range and the members of struct iova: 1. static int __alloc_and_insert_iova_range(struct iova_domain *iovad, unsigned long size, unsigned long limit_pfn, 2. struct iova { unsigned long pfn_hi; unsigned long pfn_lo; In fact, limit_pfn is most likely larger than 32 bits on DMA64. Signed-off-by: Zhen Lei --- drivers/iommu/iova.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/iova.c b/drivers/iommu/iova.c index b7268a1..8ba8b496 100644 --- a/drivers/iommu/iova.c +++ b/drivers/iommu/iova.c @@ -104,8 +104,8 @@ __cached_rbnode_delete_update(struct iova_domain *iovad, struct iova *free) * Computes the padding size required, to make the start address * naturally aligned on the power-of-two order of its size */ -static unsigned int -iova_get_pad_size(unsigned int size, unsigned int limit_pfn) +static unsigned long +iova_get_pad_size(unsigned long size, unsigned long limit_pfn) { return (limit_pfn + 1 - size) & (__roundup_pow_of_two(size) - 1); } @@ -117,7 +117,7 @@ static int __alloc_and_insert_iova_range(struct iova_domain *iovad, struct rb_node *prev, *curr = NULL; unsigned long flags; unsigned long saved_pfn; - unsigned int pad_size = 0; + unsigned long pad_size = 0; /* Walk the tree backwards */ spin_lock_irqsave(&iovad->iova_rbtree_lock, flags); -- 2.5.0