linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>
Subject: [PATCH v4 1/6] pinctrl: samsung: Ensure that pad retention is disabled on driver init
Date: Thu, 23 Mar 2017 09:03:22 +0100	[thread overview]
Message-ID: <1490256207-10061-2-git-send-email-m.szyprowski@samsung.com> (raw)
In-Reply-To: <1490256207-10061-1-git-send-email-m.szyprowski@samsung.com>

When pin controller device is a part of power domain, there is no guarantee
that the power domain was not turned off and then on during boot process
before probing of the pin control driver. If it happened, then pin control
driver should ensure that pad retention is turned off during its probe call.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/pinctrl/samsung/pinctrl-exynos.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c
index f9b49967f512..fa8bdd9ae198 100644
--- a/drivers/pinctrl/samsung/pinctrl-exynos.c
+++ b/drivers/pinctrl/samsung/pinctrl-exynos.c
@@ -777,6 +777,7 @@ static void exynos_retention_disable(struct samsung_pinctrl_drv_data *drvdata)
 {
 	struct samsung_retention_ctrl *ctrl;
 	struct regmap *pmu_regs;
+	int i;
 
 	ctrl = devm_kzalloc(drvdata->dev, sizeof(*ctrl), GFP_KERNEL);
 	if (!ctrl)
@@ -794,6 +795,10 @@ static void exynos_retention_disable(struct samsung_pinctrl_drv_data *drvdata)
 	ctrl->enable = exynos_retention_enable;
 	ctrl->disable = exynos_retention_disable;
 
+	/* Ensure that retention is disabled on driver init */
+	for (i = 0; i < ctrl->nr_regs; i++)
+		regmap_write(pmu_regs, ctrl->regs[i], ctrl->value);
+
 	return ctrl;
 }
 
-- 
1.9.1

  parent reply	other threads:[~2017-03-23  8:04 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170323080346eucas1p216eec41325d220774ecec05b397e83a6@eucas1p2.samsung.com>
2017-03-23  8:03 ` [PATCH v4 0/6] Pad retentions support for Exynos5433 Marek Szyprowski
     [not found]   ` <CGME20170323080347eucas1p2d0340709543b3ce128281e5a490216d4@eucas1p2.samsung.com>
2017-03-23  8:03     ` Marek Szyprowski [this message]
2017-03-23 19:14       ` [PATCH v4 1/6] pinctrl: samsung: Ensure that pad retention is disabled on driver init Krzysztof Kozlowski
     [not found]   ` <CGME20170323080348eucas1p188a598869b71a1302160df46839b3ca8@eucas1p1.samsung.com>
2017-03-23  8:03     ` [PATCH v4 2/6] pinctrl: samsung: Add support for pad retention control for Exynos5433 SoCs Marek Szyprowski
2017-03-23 19:15       ` Krzysztof Kozlowski
     [not found]   ` <CGME20170323080348eucas1p29d1fb4eb06e4785d20341be7a374bfb3@eucas1p2.samsung.com>
2017-03-23  8:03     ` [PATCH v4 3/6] mfd: exynos-lpass: Remove pad retention control Marek Szyprowski
2017-04-11 12:02       ` Lee Jones
2017-04-19 11:00         ` Marek Szyprowski
2017-04-24 10:35           ` Lee Jones
     [not found]   ` <CGME20170323080349eucas1p11187befd30ab70554373fb6d818cd851@eucas1p1.samsung.com>
2017-03-23  8:03     ` [PATCH v4 4/6] mfd: exynos-lpass: Add support for clocks Marek Szyprowski
2017-04-11 12:03       ` Lee Jones
     [not found]   ` <CGME20170323080349eucas1p24093d55f6654274e0c0bdf02d477c906@eucas1p2.samsung.com>
2017-03-23  8:03     ` [PATCH v4 5/6] mfd: exynos-lpass: Add missing remove() function Marek Szyprowski
2017-04-11 12:03       ` Lee Jones
     [not found]   ` <CGME20170323080350eucas1p273814a2f183f04f180f8f2a2a362b86e@eucas1p2.samsung.com>
2017-03-23  8:03     ` [PATCH v4 6/6] mfd: exynos-lpass: Add runtime PM support Marek Szyprowski
2017-04-11 12:03       ` Lee Jones
2017-03-28  9:22   ` [PATCH v4 0/6] Pad retentions support for Exynos5433 Linus Walleij
2017-03-28 10:14     ` Krzysztof Kozlowski
2017-03-28 15:42   ` [GIT PULL] mfd: exynos-lpass: Pinctrl dependency Krzysztof Kozlowski
2017-04-03 10:18     ` Lee Jones
2017-04-04  8:23       ` Krzysztof Kozlowski
2017-04-04  9:50         ` Lee Jones
2017-04-04  9:57           ` Krzysztof Kozlowski
2017-04-11 11:57             ` Lee Jones
2017-04-11 11:59     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490256207-10061-2-git-send-email-m.szyprowski@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=krzk@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).