From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755486AbdCWWPS (ORCPT ); Thu, 23 Mar 2017 18:15:18 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:34644 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752942AbdCWWPQ (ORCPT ); Thu, 23 Mar 2017 18:15:16 -0400 Message-ID: <1490307306.66163.8.camel@gmail.com> Subject: Re: [PATCH] staging: wilc1000: use kernel define byte order macros From: Robert Perry Hooker To: Dan Carpenter Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, ganesh.krishna@microchip.com, linux-kernel@vger.kernel.org, aditya.shankar@microchip.com Date: Thu, 23 Mar 2017 16:15:06 -0600 In-Reply-To: <20170323083317.GM4343@mwanda> References: <1490126140-12867-1-git-send-email-perry.hooker@gmail.com> <20170321201904.GD32449@mwanda> <1490132410.17318.6.camel@gmail.com> <20170322092403.GF32449@mwanda> <1490234008.66163.1.camel@gmail.com> <20170323083317.GM4343@mwanda> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.2.1 (3.16.2.1-1.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Well, yes, all data is 'endian' one way or another, right? I guess the byte order of the tx/rx_buffers is host-endian (which could be big), or _maybe_ network-endian... Regards, Perry On Thu, 2017-03-23 at 11:33 +0300, Dan Carpenter wrote: > On Wed, Mar 22, 2017 at 07:53:28PM -0600, Robert Perry Hooker wrote: > > I don't think buff is an ieee80211_hdr struct. I think it's the rx_buffer allocated at wilc_wlan.c:1417. > > > > The rx_buffer is going to end up filled with endian data, right? > > regards, > dan carpenter >