From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753960AbdCXBIp (ORCPT ); Thu, 23 Mar 2017 21:08:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36026 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752022AbdCXBIn (ORCPT ); Thu, 23 Mar 2017 21:08:43 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 74DA67FD47 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=riel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 74DA67FD47 Message-ID: <1490317718.8850.61.camel@redhat.com> Subject: Re: [BUG nohz]: wrong user and system time accounting From: Rik van Riel To: Luiz Capitulino Cc: fweisbec@gmail.com, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Date: Thu, 23 Mar 2017 21:08:38 -0400 In-Reply-To: <20170323210541.5222eaf6@redhat.com> References: <20170323165512.60945ac6@redhat.com> <1490316962.8850.59.camel@redhat.com> <20170323210541.5222eaf6@redhat.com> Organization: Red Hat, Inc Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 24 Mar 2017 01:08:43 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-03-23 at 21:05 -0400, Luiz Capitulino wrote: > On Thu, 23 Mar 2017 20:56:02 -0400 > Rik van Riel wrote: > > > On Thu, 2017-03-23 at 16:55 -0400, Luiz Capitulino wrote: > > > When there are two or more tasks executing in user-space and > > > taking 100% of a nohz_full CPU, top reports 70% system time > > > and 30% user time utilization. Sometimes I'm even able to get > > > 100% system time and 0% user time. > > > > > > This was reproduced with latest Linus tree (093b995), but I > > > don't believe it's a regression (at least not a recent one) > > > as I can reproduce it with older kernels. Also, I have > > > CONFIG_IRQ_TIME_ACCOUNTING=y and haven't tried to reproduce > > > without it yet. > > > > > > Below you'll find the steps to reproduce and some initial > > > analysis. > > > > > > Steps to reproduce > > > ------------------ > > > > > > 1. Set up a CPU for nohz_full with isolcpus= nohz_full= > > > > > > 2. Pin two tasks that hog the CPU 100% of the time to that CPU > > > > > > 3. Run top -d1 and check system time > > > > > > NOTE: When there's only one task hogging a nohz_full CPU, top > > >       shows 100% user-time, as expected > > > > > > Initial analysis > > > ---------------- > > > > > > When tracing vtime accounting functions and the user-space/kernel > > > transitions when the issue is taking place, I see several of the > > > following: > > > > > > hog-10552 [015]  1132.711104: > > > function:             enter_from_user_mode <-- > > > apic_timer_interrupt > > > hog-10552 [015]  1132.711105: > > > function:             __context_tracking_exit <-- > > > enter_from_user_mode > > > hog-10552 [015]  1132.711105: > > > bprint:               __context_tracking_exit.part.4: new state=1 > > > cur > > > state=1 active=1 > > > hog-10552 [015]  1132.711105: > > > function:             vtime_account_user <-- > > > __context_tracking_exit.part.4 > > > hog-10552 [015]  1132.711105: > > > function:             smp_apic_timer_interrupt <-- > > > apic_timer_interrupt > > > hog-10552 [015]  1132.711106: function:             irq_enter <-- > > > smp_apic_timer_interrupt > > > hog-10552 [015]  1132.711106: > > > function:             tick_sched_timer > > > <-- __hrtimer_run_queues > > > hog-10552 [015]  1132.711108: function:             irq_exit <-- > > > smp_apic_timer_interrupt > > > hog-10552 [015]  1132.711108: > > > function:             __context_tracking_enter <-- > > > prepare_exit_to_usermode > > > hog-10552 [015]  1132.711108: > > > bprint:               __context_tracking_enter.part.2: new > > > state=1 > > > cur state=0 active=1 > > > hog-10552 [015]  1132.711109: > > > function:             vtime_user_enter > > > <-- __context_tracking_enter.part.2 > > > hog-10552 [015]  1132.711109: > > > function:             __vtime_account_system <-- vtime_user_enter > > > hog-10552 [015]  1132.711109: > > > function:             account_system_time <-- > > > __vtime_account_system > > > > > > On entering the kernel due to a timer interrupt, > > > vtime_account_user() > > > skips user-time accounting. Then later on when returning to user- > > > space, > > > vtime_user_enter() is probably accounting the whole time (ie. > > > user- > > > space > > > plus kernel-space) to system time. > > > > > > Now, when does vtime_account_user() skips accounting? Well, when > > > the > > > time delta is less then one jiffie. This would imply that > > > vtime_account_user() > > > is being called less than one jiffie since the last accounting, > > > but I > > > haven't > > > confirmed any of this yet.   > > > > Jiffies should be advanced by the timer interrupt, on the > > housekeeping CPU, which is not doing context tracking. > > The hypothesis isn't that it wasn't advanced, but that we stayed in > user-space less than 1ms. That is part of the hypothesis. The other part of the hypothesis involves jiffies advancing on the nohz_full & isolated CPU while that CPU is in kernel mode 30% of the time. I have no good explanation for the latter yet... > > Why is the isolated/nohz_full CPU receiving timer interrupts > > at all? > > > > I thought it would not, but obviously I am wrong. What is > > going on here? > > There are two runnable SCHED_OTHER tasks on the nohz_full CPU. When > that happens, the tick is re-activated. We're not nohz_full anymore, > but accounting should still work. Isn't the scheduler tick distinct from the timer interrupt, or am I confused?