From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752195AbdC1PvX (ORCPT ); Tue, 28 Mar 2017 11:51:23 -0400 Received: from mail-wr0-f174.google.com ([209.85.128.174]:33715 "EHLO mail-wr0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbdC1PvV (ORCPT ); Tue, 28 Mar 2017 11:51:21 -0400 Message-ID: <1490716277.20764.6.camel@baylibre.com> Subject: Re: [PATCH v2,1/3] meson_uart: expose CLKID_UARTx From: Jerome Brunet To: Helmut Klein , mturquette@baylibre.com, sboyd@codeaurora.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Tue, 28 Mar 2017 17:51:17 +0200 In-Reply-To: <20170328092545.4644-2-hgkr.klein@gmail.com> References: <20170328092545.4644-1-hgkr.klein@gmail.com> <20170328092545.4644-2-hgkr.klein@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-1.fc25) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-03-28 at 11:25 +0200, Helmut Klein wrote: > Expose the clock ids for the three none AO uarts to the dt-bindings Are they all used in the device tree ? We try to only expose what we need in the DT The recent discussion over CLKID_CPUCLK proved it was a sane thing to do. > > Signed-off-by: Helmut Klein > --- >  drivers/clk/meson/gxbb.h              | 6 +++--- >  include/dt-bindings/clock/gxbb-clkc.h | 3 +++ >  2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/meson/gxbb.h b/drivers/clk/meson/gxbb.h > index 8ee2022ce5d5..1edfaa5fe307 100644 > --- a/drivers/clk/meson/gxbb.h > +++ b/drivers/clk/meson/gxbb.h > @@ -194,7 +194,7 @@ >  /* #define CLKID_SAR_ADC */ >  #define CLKID_SMART_CARD   24 >  #define CLKID_RNG0   25 > -#define CLKID_UART0   26 > +/* CLKID_UART0 */ >  #define CLKID_SDHC   27 >  #define CLKID_STREAM   28 >  #define CLKID_ASYNC_FIFO   29 > @@ -216,7 +216,7 @@ >  #define CLKID_ADC   45 >  #define CLKID_BLKMV   46 >  #define CLKID_AIU   47 > -#define CLKID_UART1   48 > +/* CLKID_UART1 */ >  #define CLKID_G2D   49 >  /* CLKID_USB0 */ >  /* CLKID_USB1 */ > @@ -236,7 +236,7 @@ >  /* CLKID_USB0_DDR_BRIDGE */ >  #define CLKID_MMC_PCLK   66 >  #define CLKID_DVIN   67 > -#define CLKID_UART2   68 > +/* CLKID_UART2 */ >  /* #define CLKID_SANA */ >  #define CLKID_VPU_INTR   70 >  #define CLKID_SEC_AHB_AHB3_BRIDGE 71 > diff --git a/include/dt-bindings/clock/gxbb-clkc.h b/include/dt- > bindings/clock/gxbb-clkc.h > index 692846c7941b..7b329df47752 100644 > --- a/include/dt-bindings/clock/gxbb-clkc.h > +++ b/include/dt-bindings/clock/gxbb-clkc.h > @@ -15,13 +15,16 @@ >  #define CLKID_SPI 34 >  #define CLKID_I2C 22 >  #define CLKID_SAR_ADC 23 > +#define CLKID_UART0 26 >  #define CLKID_ETH 36 > +#define CLKID_UART1 48 >  #define CLKID_USB0 50 >  #define CLKID_USB1 51 >  #define CLKID_USB 55 >  #define CLKID_HDMI_PCLK 63 >  #define CLKID_USB1_DDR_BRIDGE 64 >  #define CLKID_USB0_DDR_BRIDGE 65 > +#define CLKID_UART2 68 >  #define CLKID_SANA 69 >  #define CLKID_GCLK_VENCI_INT0 77 >  #define CLKID_AO_I2C 93 > -- > 2.11.0 > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic