From: Ian Campbell <ijc@hellion.org.uk>
To: Kees Cook <keescook@chromium.org>, Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Kalle Valo <kvalo@codeaurora.org>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Olof Johansson <olof@lixom.net>,
Chris Wilson <chris@chris-wilson.co.uk>,
George Spelvin <linux@sciencehorizons.net>,
Thomas Gleixner <tglx@linutronix.de>,
Josh Poimboeuf <jpoimboe@redhat.com>,
David Windsor <dwindsor@gmail.com>,
linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: Re: [kernel-hardening] [PATCH v2 1/7] bug: Clarify help text for BUG_ON_DATA_CORRUPTION
Date: Wed, 05 Apr 2017 06:47:21 +0100 [thread overview]
Message-ID: <1491371241.22446.11.camel@hellion.org.uk> (raw)
In-Reply-To: <1491343938-75336-2-git-send-email-keescook@chromium.org>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 77fadface4f9..5ac4d1148385 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1998,9 +1998,12 @@ config BUG_ON_DATA_CORRUPTION
> > bool "Trigger a BUG when data corruption is detected"
> > select DEBUG_LIST
> > help
> > - Select this option if the kernel should BUG when it encounters
> > - data corruption in kernel memory structures when they get checked
> > - for validity.
> > + This option enables several inexpensive data corruption checks.
> > + Most of these checks normally just WARN and try to further avoid
> + the corruption. Selecting this option upgrades these to BUGs so
First it says it enables some checks, but here it says it upgrades them
to BUGs which seems inconsistent.
> + that the offending process is killed. Additionally, the system
> + owner can furhter configure the system for immediate reboots
"further"
> + (via panic_on_oops sysctl) or crash dumps.
>
> > If unsure, say N.
>
next prev parent reply other threads:[~2017-04-05 5:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 22:12 [PATCH v2] bug: further enhance use of CHECK_DATA_CORRUPTION Kees Cook
2017-04-04 22:12 ` [PATCH v2 1/7] bug: Clarify help text for BUG_ON_DATA_CORRUPTION Kees Cook
2017-04-05 5:47 ` Ian Campbell [this message]
2017-04-05 19:32 ` [kernel-hardening] " Kees Cook
2017-04-04 22:12 ` [PATCH v2 2/7] bug: Improve unlikely() in data corruption check Kees Cook
2017-04-04 22:12 ` [PATCH v2 3/7] bug: Use WARN_ONCE() for CHECK_DATA_CORRUPTION() Kees Cook
2017-04-04 22:12 ` [PATCH v2 4/7] bug: Enable DEBUG_CREDENTIALS under BUG_ON_DATA_CORRUPTION Kees Cook
2017-04-04 22:12 ` [PATCH v2 5/7] bug: Enable DEBUG_SG " Kees Cook
2017-04-04 22:12 ` [PATCH v2 6/7] notifiers: Use CHECK_DATA_CORRUPTION() on checks Kees Cook
2017-04-04 22:12 ` [PATCH v2 7/7] refcount: Check bad states with CHECK_DATA_CORRUPTION() Kees Cook
2021-01-04 23:07 ` [PATCH v2] bug: further enhance use of CHECK_DATA_CORRUPTION Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491371241.22446.11.camel@hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=dwindsor@gmail.com \
--cc=geert@linux-m68k.org \
--cc=jakub.kicinski@netronome.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@sciencehorizons.net \
--cc=mingo@kernel.org \
--cc=olof@lixom.net \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).