From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "hal.rosenstock@gmail.com" <hal.rosenstock@gmail.com>,
"elfring@users.sourceforge.net" <elfring@users.sourceforge.net>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"infinipath@intel.com" <infinipath@intel.com>,
"dledford@redhat.com" <dledford@redhat.com>,
"sean.hefty@intel.com" <sean.hefty@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 5/5] IB/qib: Adjust two size determinations in qib_init_pportdata()
Date: Wed, 5 Apr 2017 15:10:14 +0000 [thread overview]
Message-ID: <1491405013.2787.3.camel@sandisk.com> (raw)
In-Reply-To: <b5bc4160-aace-b919-7fe2-a4742d03c4ba@users.sourceforge.net>
On Wed, 2017-04-05 at 15:55 +0200, SF Markus Elfring wrote:
> - size = sizeof(struct ib_cc_congestion_setting_attr);
> - ppd->congestion_entries_shadow = kzalloc(size, GFP_KERNEL);
> + ppd->congestion_entries_shadow = kzalloc(sizeof(*ppd
> + ->congestion_entries_shadow),
> + GFP_KERNEL);
The way how the above line has been split looks really weird. Please
move the entire kzalloc() call to the next line such that "*ppd" and
"->congestion_entries_shadow" appear on the same line.
Thanks,
Bart.
next prev parent reply other threads:[~2017-04-05 15:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 13:50 [PATCH 0/5] IB/qib: Fine-tuning for four function implementations SF Markus Elfring
2017-04-05 13:51 ` [PATCH 1/5] IB/qib: Use kcalloc() in qib_init_iba7322_funcs() SF Markus Elfring
2017-04-05 14:34 ` Yuval Shaia
2017-04-05 14:54 ` SF Markus Elfring
2017-04-05 15:06 ` Johannes Thumshirn
2017-04-05 15:17 ` Yuval Shaia
2017-04-05 13:52 ` [PATCH 2/5] IB/qib: Use kmalloc_array() in qib_init_7322_variables() SF Markus Elfring
2017-04-05 14:21 ` Yuval Shaia
2017-04-05 13:53 ` [PATCH 3/5] IB/qib: Use kcalloc() in qib_alloc_devdata() SF Markus Elfring
2017-04-05 13:54 ` [PATCH 4/5] IB/qib: Use kcalloc() in qib_init_pportdata() SF Markus Elfring
2017-04-05 13:55 ` [PATCH 5/5] IB/qib: Adjust two size determinations " SF Markus Elfring
2017-04-05 14:32 ` Yuval Shaia
2017-04-05 15:04 ` SF Markus Elfring
2017-04-05 15:15 ` Yuval Shaia
2017-04-05 15:21 ` SF Markus Elfring
2017-04-06 19:48 ` Yuval Shaia
2017-04-06 20:33 ` SF Markus Elfring
2017-04-05 15:10 ` Bart Van Assche [this message]
2017-04-06 0:37 ` [PATCH 0/5] IB/qib: Fine-tuning for four function implementations Dennis Dalessandro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491405013.2787.3.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=dledford@redhat.com \
--cc=elfring@users.sourceforge.net \
--cc=hal.rosenstock@gmail.com \
--cc=infinipath@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).