From: Laura Abbott <labbott@redhat.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
Chris Wilson <chris@chris-wilson.co.uk>,
Sean Paul <seanpaul@chromium.org>
Cc: Laura Abbott <labbott@redhat.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Sumit Semwal <sumit.semwal@linaro.org>
Subject: [RFC PATCH 1/2] drm/vgem: Add a dummy platform device
Date: Thu, 6 Apr 2017 16:18:32 -0700 [thread overview]
Message-ID: <1491520713-14277-2-git-send-email-labbott@redhat.com> (raw)
In-Reply-To: <1491520713-14277-1-git-send-email-labbott@redhat.com>
The vgem driver is currently registered independent of any actual
device. Some usage of the dmabuf APIs require an actual device structure
to do anything. Register a dummy platform device for use with dmabuf.
Signed-off-by: Laura Abbott <labbott@redhat.com>
---
I realize the original driver had a note about 'drop platform support'. I
strongly dislike platform devices but they are the easiest way to get a device
structure for use with APIs like dmabuf.
---
drivers/gpu/drm/vgem/vgem_drv.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index a1f42d1..b94feef 100644
--- a/drivers/gpu/drm/vgem/vgem_drv.c
+++ b/drivers/gpu/drm/vgem/vgem_drv.c
@@ -329,12 +329,19 @@ static struct drm_driver vgem_driver = {
};
static struct drm_device *vgem_device;
+static struct platform_device *vgem_pdev;
static int __init vgem_init(void)
{
int ret;
- vgem_device = drm_dev_alloc(&vgem_driver, NULL);
+ vgem_pdev = platform_device_register_simple("vgem", -1, NULL, 0);
+ if (IS_ERR(vgem_pdev))
+ return PTR_ERR(vgem_pdev);
+
+ dma_coerce_mask_and_coherent(&vgem_pdev->dev, DMA_BIT_MASK(64));
+
+ vgem_device = drm_dev_alloc(&vgem_driver, &vgem_pdev->dev);
if (IS_ERR(vgem_device)) {
ret = PTR_ERR(vgem_device);
goto out;
@@ -349,6 +356,8 @@ static int __init vgem_init(void)
out_unref:
drm_dev_unref(vgem_device);
out:
+ platform_device_unregister(vgem_pdev);
+
return ret;
}
@@ -356,6 +365,7 @@ static void __exit vgem_exit(void)
{
drm_dev_unregister(vgem_device);
drm_dev_unref(vgem_device);
+ platform_device_unregister(vgem_pdev);
}
module_init(vgem_init);
--
2.7.4
next prev parent reply other threads:[~2017-04-06 23:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 23:18 [RFC PATCH 0/2] dmabuf import interfaces for vgem Laura Abbott
2017-04-06 23:18 ` Laura Abbott [this message]
2017-04-06 23:18 ` [RFC PATCH 2/2] drm/vgem: Enable dmabuf import interfaces Laura Abbott
2017-04-07 7:39 ` Chris Wilson
2017-04-07 16:18 ` Laura Abbott
2017-04-07 16:58 ` Chris Wilson
2017-04-07 17:58 ` Laura Abbott
2017-04-07 21:22 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491520713-14277-2-git-send-email-labbott@redhat.com \
--to=labbott@redhat.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanpaul@chromium.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).