From: Deepa Dinamani <deepa.kernel@gmail.com>
To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Cc: tglx@linutronix.de, viro@zeniv.linux.org.uk,
gregkh@linuxfoundation.org, andreas.dilger@intel.com,
arnd@arndb.de, bfields@fieldses.org, clm@fb.com,
davem@davemloft.net, dsterba@suse.com, dushistov@mail.ru,
eparis@redhat.com, jaegeuk@kernel.org, jbacik@fb.com,
jlayton@poochiereds.net, john.stultz@linaro.org,
jsimmons@infradead.org, mingo@redhat.com, oleg.drokin@intel.com,
paul@paul-moore.com, rostedt@goodmis.org, yuchao0@huawei.com,
ceph-devel@vger.kernel.org, devel@driverdev.osuosl.org,
linux-audit@redhat.com, linux-btrfs@vger.kernel.org,
linux-cifs@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-security-module@vger.kernel.org,
lustre-devel@lists.lustre.org, netdev@vger.kernel.org,
samba-technical@lists.samba.org, y2038@lists.linaro.org
Subject: [PATCH 01/12] fs: f2fs: Use ktime_get_real_seconds for sit_info times
Date: Fri, 7 Apr 2017 17:56:59 -0700 [thread overview]
Message-ID: <1491613030-11599-2-git-send-email-deepa.kernel@gmail.com> (raw)
In-Reply-To: <1491613030-11599-1-git-send-email-deepa.kernel@gmail.com>
CURRENT_TIME_SEC is not y2038 safe.
Replace use of CURRENT_TIME_SEC with ktime_get_real_seconds
in segment timestamps used by GC algorithm including the
segment mtime timestamps.
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
---
fs/f2fs/segment.c | 2 +-
fs/f2fs/segment.h | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 010324c..0531500 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -2678,7 +2678,7 @@ static int build_sit_info(struct f2fs_sb_info *sbi)
sit_i->dirty_sentries = 0;
sit_i->sents_per_block = SIT_ENTRY_PER_BLOCK;
sit_i->elapsed_time = le64_to_cpu(sbi->ckpt->elapsed_time);
- sit_i->mounted_time = CURRENT_TIME_SEC.tv_sec;
+ sit_i->mounted_time = ktime_get_real_seconds();
mutex_init(&sit_i->sentry_lock);
return 0;
}
diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h
index 57e36c1..156afc3 100644
--- a/fs/f2fs/segment.h
+++ b/fs/f2fs/segment.h
@@ -692,8 +692,9 @@ static inline void set_to_next_sit(struct sit_info *sit_i, unsigned int start)
static inline unsigned long long get_mtime(struct f2fs_sb_info *sbi)
{
struct sit_info *sit_i = SIT_I(sbi);
- return sit_i->elapsed_time + CURRENT_TIME_SEC.tv_sec -
- sit_i->mounted_time;
+ time64_t now = ktime_get_real_seconds();
+
+ return sit_i->elapsed_time + now - sit_i->mounted_time;
}
static inline void set_summary(struct f2fs_summary *sum, nid_t nid,
--
2.7.4
next prev parent reply other threads:[~2017-04-08 0:58 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 0:56 [PATCH 00/12] Delete CURRENT_TIME, CURRENT_TIME_SEC and current_fs_time Deepa Dinamani
2017-04-08 0:56 ` Deepa Dinamani [this message]
2017-04-08 0:57 ` [PATCH 02/12] trace: Make trace_hwlat timestamp y2038 safe Deepa Dinamani
2017-04-08 1:30 ` Steven Rostedt
2017-04-08 2:16 ` Deepa Dinamani
2017-04-08 0:57 ` [PATCH 03/12] fs: cifs: Replace CURRENT_TIME by other appropriate apis Deepa Dinamani
2017-04-08 0:57 ` [PATCH 04/12] fs: ceph: CURRENT_TIME with ktime_get_real_ts() Deepa Dinamani
2017-06-01 9:56 ` Yan, Zheng
2017-06-01 10:22 ` Arnd Bergmann
2017-06-02 0:26 ` Yan, Zheng
2017-06-02 0:36 ` John Stultz
2017-06-02 0:57 ` Deepa Dinamani
2017-06-02 2:09 ` Yan, Zheng
2017-06-02 9:45 ` Arnd Bergmann
2017-06-02 10:10 ` Yan, Zheng
2017-06-02 10:51 ` Arnd Bergmann
2017-06-02 11:18 ` Yan, Zheng
2017-06-02 11:33 ` Arnd Bergmann
2017-06-02 12:18 ` Yan, Zheng
2017-06-02 14:18 ` Arnd Bergmann
2017-06-04 7:54 ` Yan, Zheng
2017-06-02 0:35 ` Yan, Zheng
2017-04-08 0:57 ` [PATCH 05/12] fs: ufs: Use ktime_get_real_ts64() for birthtime Deepa Dinamani
2017-04-08 0:57 ` [PATCH 06/12] audit: Use timespec64 to represent audit timestamps Deepa Dinamani
2017-04-08 12:40 ` Paul Moore
2017-04-08 17:58 ` Deepa Dinamani
2017-04-11 20:12 ` Paul Moore
2017-04-15 10:29 ` Arnd Bergmann
2017-04-08 0:57 ` [PATCH 07/12] fs: btrfs: Use ktime_get_real_ts for root ctime Deepa Dinamani
2017-04-12 13:42 ` David Sterba
2017-04-08 0:57 ` [PATCH 08/12] fs: ubifs: Replace CURRENT_TIME_SEC with current_time Deepa Dinamani
2017-04-08 0:57 ` [PATCH 09/12] lustre: Replace CURRENT_TIME macro Deepa Dinamani
2017-04-08 0:57 ` [PATCH 10/12] apparmorfs: Replace CURRENT_TIME with current_time() Deepa Dinamani
2017-06-02 7:29 ` John Johansen
2017-04-08 0:57 ` [PATCH 11/12] time: Delete CURRENT_TIME_SEC and CURRENT_TIME Deepa Dinamani
2017-04-08 0:57 ` [PATCH 12/12] time: Delete current_fs_time() function Deepa Dinamani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491613030-11599-2-git-send-email-deepa.kernel@gmail.com \
--to=deepa.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andreas.dilger@intel.com \
--cc=arnd@arndb.de \
--cc=bfields@fieldses.org \
--cc=ceph-devel@vger.kernel.org \
--cc=clm@fb.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=dsterba@suse.com \
--cc=dushistov@mail.ru \
--cc=eparis@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jaegeuk@kernel.org \
--cc=jbacik@fb.com \
--cc=jlayton@poochiereds.net \
--cc=john.stultz@linaro.org \
--cc=jsimmons@infradead.org \
--cc=linux-audit@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=paul@paul-moore.com \
--cc=rostedt@goodmis.org \
--cc=samba-technical@lists.samba.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=y2038@lists.linaro.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).