linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Karim Eshapa <karim.eshapa@gmail.com>
To: gregkh@linuxfoundation.org
Cc: jason@lakedaemon.net, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org,
	Karim Eshapa <karim.eshapa@gmail.com>
Subject: Re:staging:skein: skein_base.h, skein_block.h: move macros into appropriate header files
Date: Mon, 17 Apr 2017 17:04:28 +0200	[thread overview]
Message-ID: <1492441468-4957-1-git-send-email-karim.eshapa@gmail.com> (raw)
In-Reply-To: <20170417070403.GA23282@kroah.com>

On Mon, 17 Apr 2017 09:04:03 +0200, Greg KH wrote:
> On Mon, Apr 17, 2017 at 02:47:34AM +0200, Karim Eshapa wrote:
>>
>> Macros more related to BLK operations. 
>
> That doesn't make any sense to me, can you be more explicit?.

skein_block.h contains all fn's related to processing on 
different block size so , it's more finer to contain macros
that define block configuration, message,.. specially they
aren't even referenced in all files that include skein_base.h
but these macros I think still exist in driver files for future work as well.

> Moving stuff from one file to another doesn't seem like it is really
> worth it.
> And where is patch 1/2 in this series?

And, Moving stuff is what "TODO" see it is worth.
There is no patch1/2 sorry, but may be because I sent
the patch twice as one of the mails was witten wrong.

>> Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>
>> ---
>> drivers/staging/skein/skein_base.h  | 28 ----------------------------
>> drivers/staging/skein/skein_block.h | 28 ++++++++++++++++++++++++++++
>>  2 files changed, 28 insertions(+), 28 deletions(-)

Thanks,
Karim

      reply	other threads:[~2017-04-17 15:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-17  0:47 [PATCH 2/2] staging:skein: skein_base.h, skein_block.h: move macros into appropriate header files Karim Eshapa
2017-04-17  7:04 ` Greg KH
2017-04-17 15:04   ` Karim Eshapa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492441468-4957-1-git-send-email-karim.eshapa@gmail.com \
    --to=karim.eshapa@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jason@lakedaemon.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).