From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754905AbdDQSXY (ORCPT ); Mon, 17 Apr 2017 14:23:24 -0400 Received: from botnar.kaiser.cx ([176.28.20.183]:49350 "EHLO botnar.kaiser.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754524AbdDQSXV (ORCPT ); Mon, 17 Apr 2017 14:23:21 -0400 From: Martin Kaiser To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Arnd Bergmann , Martin Kaiser Subject: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry Date: Mon, 17 Apr 2017 20:22:57 +0200 Message-Id: <1492453377-23796-2-git-send-email-martin@kaiser.cx> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1492453377-23796-1-git-send-email-martin@kaiser.cx> References: <1488234485-26111-1-git-send-email-martin@kaiser.cx> <1492453377-23796-1-git-send-email-martin@kaiser.cx> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Set the permissions for /proc/misc to 0444 explicitly. At the moment, we're using 0 and have proc_create_data() convert this to 0444. This fixes a checkpatch warning. Signed-off-by: Martin Kaiser --- v2: separate patch for each checkpatch warning drivers/char/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index 3447b2e..3c633d5 100644 --- a/drivers/char/misc.c +++ b/drivers/char/misc.c @@ -280,7 +280,7 @@ static int __init misc_init(void) int err; struct proc_dir_entry *ret; - ret = proc_create("misc", 0, NULL, &misc_proc_fops); + ret = proc_create("misc", 0444, NULL, &misc_proc_fops); misc_class = class_create(THIS_MODULE, "misc"); err = PTR_ERR(misc_class); if (IS_ERR(misc_class)) -- 1.7.10.4