From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755794AbdDRJjj (ORCPT ); Tue, 18 Apr 2017 05:39:39 -0400 Received: from s3.sipsolutions.net ([5.9.151.49]:46924 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754537AbdDRJja (ORCPT ); Tue, 18 Apr 2017 05:39:30 -0400 Message-ID: <1492508367.2472.9.camel@sipsolutions.net> Subject: Re: [RFC PATCH 9/9] debugfs: free debugfs_fsdata instances From: Johannes Berg To: paulmck@linux.vnet.ibm.com, Nicolai Stange Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Date: Tue, 18 Apr 2017 11:39:27 +0200 In-Reply-To: <20170417160121.GP3956@linux.vnet.ibm.com> References: <871stdyg0u.fsf@gmail.com> <20170416095137.2784-1-nicstange@gmail.com> <20170416095137.2784-10-nicstange@gmail.com> <20170417160121.GP3956@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-04-17 at 09:01 -0700, Paul E. McKenney wrote: > If you have not already done so, please run this with debug enabled, > especially CONFIG_PROVE_LOCKING=y (which implies CONFIG_PROVE_RCU=y). > This is important because there are configurations for which the > deadlocks you saw with SRCU turn into silent failure, including > memory corruption. > CONFIG_PROVE_RCU=y will catch many of those situations. Can you elaborate on that? I think we may have had CONFIG_PROVE_RCU enabled in the builds where we saw the problem, but I'm not sure. Can you say which configurations you're thinking of? And perhaps what kind of corruption you're thinking of also? I'm having a hard time imagining any corruption that should happen? Nicolai probably never even ran into this problem, though it should be easy to reproduce. johannes