From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933205AbdDSCXT (ORCPT ); Tue, 18 Apr 2017 22:23:19 -0400 Received: from smtprelay0239.hostedemail.com ([216.40.44.239]:48788 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932779AbdDSCXR (ORCPT ); Tue, 18 Apr 2017 22:23:17 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3870:3872:3873:3874:4321:5007:6742:8531:9010:10004:10400:10848:11026:11232:11658:11914:12679:12740:12760:12895:13069:13311:13357:13439:13972:14181:14659:14721:21080:21451:21611:30029:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: fear96_56353f424bd00 X-Filterd-Recvd-Size: 2819 Message-ID: <1492568591.8661.53.camel@perches.com> Subject: Re: [PATCH v13 03/10] mux: minimal mux subsystem and gpio-based mux controller From: Joe Perches To: Peter Rosin , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Wolfram Sang , Rob Herring , Mark Rutland , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Corbet , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-doc@vger.kernel.org, Andrew Morton , Colin Ian King , Paul Gortmaker , Philipp Zabel , kernel@pengutronix.de Date: Tue, 18 Apr 2017 19:23:11 -0700 In-Reply-To: References: <1492101794-13444-1-git-send-email-peda@axentia.se> <1492101794-13444-4-git-send-email-peda@axentia.se> <20170418085156.GA4773@kroah.com> <20170418114430.GA1496@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-04-18 at 23:53 +0200, Peter Rosin wrote: > On 2017-04-18 13:44, Greg Kroah-Hartman wrote: > > On Tue, Apr 18, 2017 at 12:59:50PM +0200, Peter Rosin wrote: [] > > > > > + ret = device_add(&mux_chip->dev); > > > > > + if (ret < 0) > > > > > + dev_err(&mux_chip->dev, > > > > > + "device_add failed in mux_chip_register: %d\n", ret); > > > > > > > > Did you run checkpatch.pl in strict mode on this new file? Please do so :) > > > > > > I did, and did it again just to be sure, and I do not get any complaints. > > > So, what's wrong? > > > > You list the function name in the printk string, it should complain > > that __func__ should be used. Oh well, it's just a perl script, it > > doesn't always catch everything. > > isn't always correct :) > > Ah, ok. Also, please use the checkpatch in -next as it has a slightly better mechanism to identify functions and uses in strings. $ ./scripts/checkpatch.pl ~/1.patch WARNING: Prefer using '"%s...", __func__' to using 'mux_chip_register', this function's name, in a string #302: FILE: drivers/mux/mux-core.c:134: + "device_add failed in mux_chip_register: %d\n", ret);