linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Razmik Karapetyan <Razmik.Karapetyan@synopsys.com>,
	John Youn <John.Youn@synopsys.com>,
	Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: dwc2: Remove unnecessary debug prints
Date: Wed, 19 Apr 2017 14:55:50 -0700	[thread overview]
Message-ID: <1492638950.30293.6.camel@perches.com> (raw)
In-Reply-To: <efeef059-0420-4d7a-8b3b-b053ad071149@US01WEHTC2.internal.synopsys.com>

On Wed, 2017-04-19 at 15:16 +0400, Razmik Karapetyan wrote:
> Removed unnecessary debug prints about DMA mode for host side
> from dwc2_gahbcfg_init() function.

Why are these unnecessary?  Are these emitted elsewhere?

and...

> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
[]
> @@ -302,22 +302,10 @@ static int dwc2_gahbcfg_init(struct dwc2_hsotg *hsotg)
[]
>  	if (hsotg->params.host_dma)
>  		ahbcfg |= GAHBCFG_DMA_EN;
> +	else
> +		hsotg->params.dma_desc_enable = false;

This change isn't mentioned in the commit message.
Why is is useful?

      reply	other threads:[~2017-04-19 21:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19 11:16 Razmik Karapetyan
2017-04-19 21:55 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492638950.30293.6.camel@perches.com \
    --to=joe@perches.com \
    --cc=John.Youn@synopsys.com \
    --cc=Razmik.Karapetyan@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --subject='Re: [PATCH 1/2] usb: dwc2: Remove unnecessary debug prints' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).