From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934760AbdDSV4D (ORCPT <rfc822;w@1wt.eu>);
        Wed, 19 Apr 2017 17:56:03 -0400
Received: from smtprelay0085.hostedemail.com ([216.40.44.85]:46256 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S934577AbdDSV4A (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 19 Apr 2017 17:56:00 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1538:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3868:3870:3871:4250:4321:5007:6119:10004:10400:10848:11026:11232:11473:11658:11914:12048:12740:12760:12895:13069:13095:13311:13357:13439:14659:14721:21080:21433:21611:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none
X-HE-Tag: air75_8a7e58c7ed22c
X-Filterd-Recvd-Size: 1513
Message-ID: <1492638950.30293.6.camel@perches.com>
Subject: Re: [PATCH 1/2] usb: dwc2: Remove unnecessary debug prints
From: Joe Perches <joe@perches.com>
To: Razmik Karapetyan <Razmik.Karapetyan@synopsys.com>,
        John Youn <John.Youn@synopsys.com>, Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Wed, 19 Apr 2017 14:55:50 -0700
In-Reply-To: <efeef059-0420-4d7a-8b3b-b053ad071149@US01WEHTC2.internal.synopsys.com>
References: <efeef059-0420-4d7a-8b3b-b053ad071149@US01WEHTC2.internal.synopsys.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.6-1ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2017-04-19 at 15:16 +0400, Razmik Karapetyan wrote:
> Removed unnecessary debug prints about DMA mode for host side
> from dwc2_gahbcfg_init() function.

Why are these unnecessary?  Are these emitted elsewhere?

and...

> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
[]
> @@ -302,22 +302,10 @@ static int dwc2_gahbcfg_init(struct dwc2_hsotg *hsotg)
[]
>  	if (hsotg->params.host_dma)
>  		ahbcfg |= GAHBCFG_DMA_EN;
> +	else
> +		hsotg->params.dma_desc_enable = false;

This change isn't mentioned in the commit message.
Why is is useful?