From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967445AbdDSWYz (ORCPT ); Wed, 19 Apr 2017 18:24:55 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:32859 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936963AbdDSWYw (ORCPT ); Wed, 19 Apr 2017 18:24:52 -0400 From: Myungho Jung To: tglx@linutronix.de Cc: linux-kernel@vger.kernel.org Subject: [PATCH] timer: fix timer_migration to accept only 0 and 1 Date: Wed, 19 Apr 2017 15:24:50 -0700 Message-Id: <1492640690-3550-1-git-send-email-mhjungk@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Error is not shown by setting invalid value to timer_migration. Valid values for timer_migration should be restricted to 0 and 1. Testcase for this bug is ltp/runpwtests06. Signed-off-by: Myungho Jung --- kernel/sysctl.c | 2 ++ kernel/time/timer.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 8c8714f..21343d1 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -1176,6 +1176,8 @@ static struct ctl_table kern_table[] = { .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = timer_migration_handler, + .extra1 = &zero, + .extra2 = &one, }, #endif #ifdef CONFIG_BPF_SYSCALL diff --git a/kernel/time/timer.c b/kernel/time/timer.c index 1dc0256..cc6b6bd 100644 --- a/kernel/time/timer.c +++ b/kernel/time/timer.c @@ -241,7 +241,7 @@ int timer_migration_handler(struct ctl_table *table, int write, int ret; mutex_lock(&mutex); - ret = proc_dointvec(table, write, buffer, lenp, ppos); + ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos); if (!ret && write) timers_update_migration(false); mutex_unlock(&mutex); -- 2.7.4