From: Vikas Shivappa <vikas.shivappa@linux.intel.com>
To: vikas.shivappa@intel.com, x86@kernel.org, linux-kernel@vger.kernel.org
Cc: sai.praneeth.prakhya@intel.com, hpa@zytor.com,
tglx@linutronix.de, mingo@kernel.org, ravi.v.shankar@intel.com,
tony.luck@intel.com, fenghua.yu@intel.com,
vikas.shivappa@linux.intel.com
Subject: [PATCH 2/3] x86/intel_rdt: Trim whitespace while parsing schemata input
Date: Wed, 19 Apr 2017 16:50:03 -0700 [thread overview]
Message-ID: <1492645804-17465-3-git-send-email-vikas.shivappa@linux.intel.com> (raw)
In-Reply-To: <1492645804-17465-1-git-send-email-vikas.shivappa@linux.intel.com>
Schemata is displayed in tabular format which introduces some whitespace
to show data in a tabular format. If user wants to input the same data
that is displayed, the parsing fails. Trim the leading and trailing
whitespace to help parse such data.
Reported-by: Prakhya, Sai Praneeth <sai.praneeth.prakhya@intel.com>
Signed-off-by: Vikas Shivappa <vikas.shivappa@linux.intel.com>
Tested-by: Prakhya, Sai Praneeth <sai.praneeth.prakhya@intel.com>
---
arch/x86/kernel/cpu/intel_rdt_schemata.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/intel_rdt_schemata.c b/arch/x86/kernel/cpu/intel_rdt_schemata.c
index 9467a00..3cfa1ca 100644
--- a/arch/x86/kernel/cpu/intel_rdt_schemata.c
+++ b/arch/x86/kernel/cpu/intel_rdt_schemata.c
@@ -143,7 +143,7 @@ static int parse_line(char *line, struct rdt_resource *r)
return -EINVAL;
list_for_each_entry(d, &r->domains, list) {
if (d->id == dom_id) {
- if (r->parse_ctrlval(dom, r, d))
+ if (r->parse_ctrlval(strim(dom), r, d))
return -EINVAL;
goto next;
}
@@ -220,7 +220,7 @@ ssize_t rdtgroup_schemata_write(struct kernfs_open_file *of,
goto out;
}
for_each_enabled_rdt_resource(r) {
- if (!strcmp(resname, r->name) &&
+ if (!strcmp(strim(resname), r->name) &&
closid < r->num_closid) {
ret = parse_line(tok, r);
if (ret)
--
1.9.1
next prev parent reply other threads:[~2017-04-19 23:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 23:50 [PATCH 0/3] x86/intel_rdt: Fixes for schemata parsing issues Vikas Shivappa
2017-04-19 23:50 ` [PATCH 1/3] x86/intel_rdt: Fix padding when resource is enabled via mount Vikas Shivappa
2017-04-20 14:03 ` [tip:x86/cpu] " tip-bot for Vikas Shivappa
2017-04-19 23:50 ` Vikas Shivappa [this message]
2017-04-20 13:51 ` [PATCH 2/3] x86/intel_rdt: Trim whitespace while parsing schemata input Thomas Gleixner
2017-04-20 17:51 ` Shivappa Vikas
2017-04-20 17:52 ` Thomas Gleixner
2017-04-20 21:19 ` Shivappa Vikas
2017-04-20 14:04 ` [tip:x86/cpu] " tip-bot for Vikas Shivappa
2017-04-19 23:50 ` [PATCH 3/3] x86/intel_rdt: Return error for incorrect resource names in schemata Vikas Shivappa
2017-04-20 13:44 ` Thomas Gleixner
2017-04-20 18:57 ` Shivappa Vikas
2017-04-20 14:04 ` [tip:x86/cpu] " tip-bot for Vikas Shivappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492645804-17465-3-git-send-email-vikas.shivappa@linux.intel.com \
--to=vikas.shivappa@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=ravi.v.shankar@intel.com \
--cc=sai.praneeth.prakhya@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vikas.shivappa@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).