From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034622AbdDUCVU (ORCPT ); Thu, 20 Apr 2017 22:21:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36930 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034535AbdDUCVR (ORCPT ); Thu, 20 Apr 2017 22:21:17 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A1513C05493F Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dledford@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A1513C05493F Message-ID: <1492741275.3041.21.camel@redhat.com> Subject: Re: linux-next: build failure after merge of the rdma tree From: Doug Ledford To: Joe Perches , Stephen Rothwell Cc: Linux-Next Mailing List , Linux Kernel Mailing List , Steve Wise Date: Thu, 20 Apr 2017 22:21:15 -0400 In-Reply-To: <1492739935.30293.20.camel@perches.com> References: <20170421114216.7878bee4@canb.auug.org.au> <1492739935.30293.20.camel@perches.com> Organization: Red Hat, Inc. Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 21 Apr 2017 02:21:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-04-20 at 18:58 -0700, Joe Perches wrote: > On Fri, 2017-04-21 at 11:42 +1000, Stephen Rothwell wrote: > > > > Hi Doug, > > > > After merging the rdma tree, today's linux-next build (powerpc > > ppc64_defconfig) failed like this: > > > > drivers/infiniband/hw/cxgb4/cm.c: In function 'send_connect': > > drivers/infiniband/hw/cxgb4/cm.c:830:5: error: implicit declaration > > of function 'PDBG' [-Werror=implicit-function-declaration] > >      PDBG("%s snd_isn %u\n", __func__, t6req->rsvd); > >      ^ > > > > Caused by commit > > > >   a9a42886d0b3 ("cxgb4: Convert PDBG to pr_debug") > > > > I have used the rdma tree from next-20170420 for today. > > > > There was another PDBG() missed in that file as well. > > Pretty sure there were crossing commits adding PDBG() > as the original patches were written against next-20170209 > > From my tree: > > $ git log --pretty=oneline -5 > 747edc68212781296de30dd2b4e63711240da7a9 > 747edc68212781296de30dd2b4e63711240da7a9 cxgb4: Convert PDBG to > pr_debug > d054cd530aeef452c7c252504f7d4d6ebba31ae3 cxgb4: Use more common > logging style > 41a74ceecd35cf2f38e2a1a1a394c7718547deb6 cxgb3: Convert PDBG to > pr_debug > 15772862930dfd2f2e10574b86c063d781976a89 cxgb3: Use more common > logging style > 9f7e70ff42dbf3af7ed0699906b699c41930b265 Add linux-next specific > files for 20170209 > > $ git grep -w PDBG 747edc68212781296de30dd2b4e63711240da7a9 > $ I created a fix and added it to my tree. -- Doug Ledford     GPG KeyID: B826A3330E572FDD     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD