linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Chandra Annamaneni <chandra627@gmail.com>
Cc: christian.gromm@microchip.com, andrey.shvetsov@k2l.de,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Staging: most: use __func__ instead of the function name
Date: Fri, 21 Apr 2017 03:30:44 -0700	[thread overview]
Message-ID: <1492770644.30293.24.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1704210039130.21893@panther>

On Fri, 2017-04-21 at 00:40 -0700, Chandra Annamaneni wrote:
> Third Reminder. Please review.

Patience.

> On Sun, 9 Apr 2017, chandrasekhar annamaneni wrote:
> > Second reminder, please review.
[]
> > On Fri, Mar 17, 2017 at 12:49 PM, Chandra Annamaneni <chandra627@gmail.com>
> > wrote:
> > 
> >       Change video.c to use %s, __func__ instead of function names.
> >       Warnings flagged by checkpatch.pl
[]
> >       diff --git a/drivers/staging/most/aim-v4l2/video.c
[]
> >       @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
> >               struct most_video_dev *mdev = video_drvdata(filp);
> >               struct aim_fh *fh;
> > 
> >       -       v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");
> >       +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);

More likely all of these should be deleted
as these seem to be function tracing logging
and ftrace works well.

see: Documentation/trace/ftrace.txt

      parent reply	other threads:[~2017-04-21 10:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-17 19:49 [PATCH v3] Staging: most: use __func__ instead of the function name Chandra Annamaneni
     [not found] ` <CAEge-i4Y9jfLjRg5pBB7vMcwLKUgPLwfvOCd65yc4_z4pp_nsQ@mail.gmail.com>
2017-04-10 11:21   ` Christian Gromm
2017-04-21  7:40   ` Chandra Annamaneni
2017-04-21  8:40     ` Greg KH
2017-04-21 18:06       ` Chandra Annamaneni
2017-04-21 18:19         ` Greg KH
2017-04-25  6:20           ` Chandra Annamaneni
2017-04-25 18:36             ` Greg KH
2017-04-26  2:28               ` Chandra Annamaneni
2017-04-26  2:55                 ` Joe Perches
2017-04-21 10:30     ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492770644.30293.24.camel@perches.com \
    --to=joe@perches.com \
    --cc=andrey.shvetsov@k2l.de \
    --cc=chandra627@gmail.com \
    --cc=christian.gromm@microchip.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).