From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S979283AbdDXXTo (ORCPT <rfc822;w@1wt.eu>);
        Mon, 24 Apr 2017 19:19:44 -0400
Received: from gate.crashing.org ([63.228.1.57]:51280 "EHLO gate.crashing.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S979111AbdDXXTi (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Apr 2017 19:19:38 -0400
Message-ID: <1493075940.25766.244.camel@kernel.crashing.org>
Subject: Re: [PATCH v4 05/11] VAS: Define helpers for access MMIO regions
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>, michael.neuling@au1.ibm.com,
        stewart@linux.vnet.ibm.com, apopple@au1.ibm.com, hbabu@us.ibm.com,
        oohall@gmail.com, bsingharora@gmail.com, linuxppc-dev@ozlabs.org,
        linux-kernel@vger.kernel.org, aneesh.kumar@linux.vnet.ibm.com
Date: Tue, 25 Apr 2017 09:19:00 +1000
In-Reply-To: <20170424172527.GA15532@us.ibm.com>
References: <1490937224-29149-1-git-send-email-sukadev@linux.vnet.ibm.com>
         <1490937224-29149-6-git-send-email-sukadev@linux.vnet.ibm.com>
         <1493015287.25766.213.camel@kernel.crashing.org>
         <20170424172527.GA15532@us.ibm.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6 (3.22.6-1.fc25) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2017-04-24 at 10:25 -0700, Sukadev Bhattiprolu wrote:
> which maybe due to this :-) Should I change to pgprot_noncached() for
> the MMIO writes?

Just use normal ioremap().

> > requires being mapped cachable. Ask Aneesh for a cleaner way of
> > doing it too while at it.