From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S980016AbdDYCWK (ORCPT ); Mon, 24 Apr 2017 22:22:10 -0400 Received: from gate.crashing.org ([63.228.1.57]:50699 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964926AbdDYCWG (ORCPT ); Mon, 24 Apr 2017 22:22:06 -0400 Message-ID: <1493086864.25766.266.camel@kernel.crashing.org> Subject: Re: [PATCH v7 4/5] i2c: aspeed: added driver for Aspeed I2C From: Benjamin Herrenschmidt To: Brendan Higgins , wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, joel@jms.id.au, vz@mleia.com, mouse@mayc.ru, clg@kaod.org Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org Date: Tue, 25 Apr 2017 12:21:04 +1000 In-Reply-To: <20170424181818.2754-5-brendanhiggins@google.com> References: <20170424181818.2754-1-brendanhiggins@google.com> <20170424181818.2754-5-brendanhiggins@google.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-1.fc25) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-04-24 at 11:18 -0700, Brendan Higgins wrote: > +static int __aspeed_i2c_init_clk(struct aspeed_i2c_bus *bus, > +                                struct platform_device *pdev) > +{ Minor nit ... I'm really not fan of those underscores. We use __ functions in some cases in the kernel for low level helpers, usually when it's a low level variant of an existing function or an "unlocked" variant, but I don't think generalizing it to pretty much everything in the driver is worthwhile here. If you want to be explicit about locking, I would suggest you use a comment in front of the function explaining if it expects to be called with the lock held. We tend to only do that when *both* functions exist and one is implemented in term of the other. Cheers, Ben.