From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "dan.j.williams@intel.com" <dan.j.williams@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
"vishal.l.verma@intel.com" <vishal.l.verma@intel.com>
Subject: Re: [PATCH] pmem: fix a NULL pointer BUG in nd_pmem_notify
Date: Tue, 25 Apr 2017 23:40:25 +0000 [thread overview]
Message-ID: <1493163594.26622.11.camel@hpe.com> (raw)
In-Reply-To: <CAPcyv4jNpCc=qCsRM0-U3Ov=iFn2e_n53_ZgPdDV3pttS0P9Ew@mail.gmail.com>
On Tue, 2017-04-25 at 16:07 -0700, Dan Williams wrote:
> On Tue, Apr 25, 2017 at 4:04 PM, Toshi Kani <toshi.kani@hpe.com>
> wrote:
> > The following BUG was observed when nd_pmem_notify() was called
> > for a BTT device. The use of a pmem_device pointer is not valid
> > with BTT.
> >
> > BUG: unable to handle kernel NULL pointer dereference at
> > 0000000000000030
> > IP: nd_pmem_notify+0x30/0xf0 [nd_pmem]
> > Call Trace:
> > nd_device_notify+0x40/0x50
> > child_notify+0x10/0x20
> > device_for_each_child+0x50/0x90
> > nd_region_notify+0x20/0x30
> > nd_device_notify+0x40/0x50
> > nvdimm_region_notify+0x27/0x30
> > acpi_nfit_scrub+0x341/0x590 [nfit]
> > process_one_work+0x197/0x450
> > worker_thread+0x4e/0x4a0
> > kthread+0x109/0x140
> >
> > Fix nd_pmem_notify() by setting nd_region and badblocks pointers
> > properly for BTT.
> >
> > Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Vishal Verma <vishal.l.verma@intel.com>
>
>
> Hi Toshi, how did you trigger this? I'd like to get your test into
> the regression suite.
Hi Dan,
I injected an error and started an ARS scan. Unfortunately, my test
steps need to run on our platforms. I think these error injection
features can be emulated, though.
Thanks,
-Toshi
next prev parent reply other threads:[~2017-04-25 23:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 23:04 [PATCH] pmem: fix a NULL pointer BUG in nd_pmem_notify Toshi Kani
2017-04-25 23:07 ` Dan Williams
2017-04-25 23:40 ` Kani, Toshimitsu [this message]
2017-04-26 14:05 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493163594.26622.11.camel@hpe.com \
--to=toshi.kani@hpe.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).