linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Galbraith <efault@gmx.de>
To: paulmck@linux.vnet.ibm.com
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: TREE_SRCU slows hotplug by factor ~16
Date: Thu, 27 Apr 2017 07:44:00 +0200	[thread overview]
Message-ID: <1493271840.4154.25.camel@gmx.de> (raw)
In-Reply-To: <20170427053228.GA11107@linux.vnet.ibm.com>

On Wed, 2017-04-26 at 22:32 -0700, Paul E. McKenney wrote:
> On Thu, Apr 27, 2017 at 06:15:56AM +0200, Mike Galbraith wrote:
> > On Wed, 2017-04-26 at 21:11 -0700, Paul E. McKenney wrote:
> > 
> > > This is with srcutree.exp_holdoff set to 25*1000?
> > 
> > Yup.
> 
> And please see below for the trivial patch, just for confirmation.
> May I add your Tested-by?

Sure.

> diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
> index ccbe1fb84165..65f03bca5b32 100644
> --- a/kernel/rcu/srcutree.c
> +++ b/kernel/rcu/srcutree.c
> @@ -39,7 +39,7 @@
>  
>  #include "rcu.h"
>  
> -ulong exp_holdoff = 50 * 1000; /* Holdoff (ns) for auto-expediting. */
> +ulong exp_holdoff = 25 * 1000; /* Holdoff (ns) for auto-expediting. */

Yup, exactly what I did.

  reply	other threads:[~2017-04-27  5:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-24  2:48 TREE_SRCU slows hotplug by factor ~16 Mike Galbraith
2017-04-24  3:32 ` Paul E. McKenney
2017-04-24  5:24   ` Mike Galbraith
2017-04-24  6:22     ` Paul E. McKenney
2017-04-24  7:35       ` Mike Galbraith
2017-04-24  8:43         ` Mike Galbraith
2017-04-24 16:24         ` Paul E. McKenney
2017-04-25 22:36           ` Paul E. McKenney
2017-04-26 14:31             ` Paul E. McKenney
2017-04-26 15:26               ` Mike Galbraith
2017-04-26 15:44                 ` Paul E. McKenney
2017-04-26 15:49                   ` Mike Galbraith
2017-04-26 16:00                     ` Paul E. McKenney
2017-04-26 17:45                     ` Mike Galbraith
2017-04-26 17:55                       ` Paul E. McKenney
2017-04-26 17:56                         ` Paul E. McKenney
2017-04-26 18:12                           ` Mike Galbraith
2017-04-26 18:25                             ` Paul E. McKenney
2017-04-27  3:43                             ` Mike Galbraith
2017-04-27  4:11                               ` Paul E. McKenney
2017-04-27  4:15                                 ` Mike Galbraith
2017-04-27  5:32                                   ` Paul E. McKenney
2017-04-27  5:44                                     ` Mike Galbraith [this message]
2017-04-27 12:37                                       ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493271840.4154.25.camel@gmx.de \
    --to=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).