From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939195AbdD0QAP (ORCPT ); Thu, 27 Apr 2017 12:00:15 -0400 Received: from smtprelay0131.hostedemail.com ([216.40.44.131]:47535 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753351AbdD0QAI (ORCPT ); Thu, 27 Apr 2017 12:00:08 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:421:541:599:967:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2565:2682:2685:2693:2736:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3167:3353:3622:3865:3866:3867:3868:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:4470:5007:6119:7903:7974:8957:9025:10004:10400:10848:11232:11658:11914:12043:12296:12555:12663:12740:12760:12895:12986:13069:13311:13357:13439:14181:14659:14721:21080:21451:30012:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: beef17_7417e2e1d8f3f X-Filterd-Recvd-Size: 2435 Message-ID: <1493308796.18659.45.camel@perches.com> Subject: Re: [PATCH] checkpatch: add --typedefsfile From: Joe Perches To: Jerome Forissier , Andy Whitcroft , linux-kernel@vger.kernel.org Cc: Andrew Morton Date: Thu, 27 Apr 2017 08:59:56 -0700 In-Reply-To: References: <1492706988.30293.13.camel@perches.com> <573fcc18-c0c4-6fcb-e16b-af4bfe86e75e@linaro.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-04-27 at 17:41 +0200, Jerome Forissier wrote: > On 04/21/2017 08:31 AM, Jerome Forissier wrote: > > On 04/20/2017 06:49 PM, Joe Perches wrote: > > > On Thu, 2017-04-20 at 17:39 +0200, Jerome Forissier wrote: > > > > When using checkpatch on out-of-tree code, it may occur that some > > > > project-specific types are used, which will cause spurious warnings. > > > > Add the --typedefsfile option as a way to extend the known types and > > > > deal with this issue. > > > > > > I'm not opposed to the addition. > > > What out-of-tree project is this for? > > > > OP-TEE [1]. We run a Travis job on all pull requests [2], and checkpatch > > is part of that. The typical false warning we get on a regular basis is > > with some pointers to functions returning TEE_Result [3], which is a > > typedef from the GlobalPlatform APIs. We consider it is acceptable to > > use GP types in the OP-TEE core implementation, that's why this patch > > would be helpful for us. > > > > [1] https://github.com/OP-TEE/optee_os > > [2] https://travis-ci.org/OP-TEE/optee_os/builds > > [3] https://travis-ci.org/OP-TEE/optee_os/builds/193355335#L1733 > > Ping? It's a well written patch. But I'll leave it up to Andrew Morton to accept/reject this. I'm not opposed to it though as it seems reasonable because using a checkpatch command-line --ignore=NEW_TYPEDEFS may not be the right solution for your use case.