* [PATCH v2 1/3] ARM: BCM: Enable thermal support for iProc SoCs
2017-04-27 21:23 [PATCH v2 0/3] thermal: broadcom: Add NSP Thermal Support Jon Mason
@ 2017-04-27 21:23 ` Jon Mason
2017-04-27 23:10 ` Scott Branden
2017-04-27 21:23 ` [PATCH v2 2/3] thermal: broadcom: ns-thermal: default on " Jon Mason
2017-04-27 21:23 ` [PATCH v2 3/3] ARM: dts: NSP: Add Thermal Support Jon Mason
2 siblings, 1 reply; 6+ messages in thread
From: Jon Mason @ 2017-04-27 21:23 UTC (permalink / raw)
To: Florian Fainelli, Zhang Rui, Eduardo Valentin, Rob Herring, Mark Rutland
Cc: bcm-kernel-feedback-list, linux-arm-kernel, linux-kernel,
linux-pm, devicetree
Change the iProc Kconfig to select THERMAL and THERMAL_OF, which allows
the ns-thermal driver to be selected via menuconfig.
Signed-off-by: Jon Mason <jon.mason@broadcom.com>
---
arch/arm/mach-bcm/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
index a0e66d8..da2bfeb 100644
--- a/arch/arm/mach-bcm/Kconfig
+++ b/arch/arm/mach-bcm/Kconfig
@@ -19,6 +19,8 @@ config ARCH_BCM_IPROC
select GPIOLIB
select ARM_AMBA
select PINCTRL
+ select THERMAL
+ select THERMAL_OF
help
This enables support for systems based on Broadcom IPROC architected SoCs.
The IPROC complex contains one or more ARM CPUs along with common
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/3] ARM: BCM: Enable thermal support for iProc SoCs
2017-04-27 21:23 ` [PATCH v2 1/3] ARM: BCM: Enable thermal support for iProc SoCs Jon Mason
@ 2017-04-27 23:10 ` Scott Branden
2017-04-28 18:05 ` Jon Mason
0 siblings, 1 reply; 6+ messages in thread
From: Scott Branden @ 2017-04-27 23:10 UTC (permalink / raw)
To: Jon Mason, Florian Fainelli, Zhang Rui, Eduardo Valentin,
Rob Herring, Mark Rutland
Cc: bcm-kernel-feedback-list, linux-arm-kernel, linux-kernel,
linux-pm, devicetree
On 17-04-27 02:23 PM, Jon Mason wrote:
> Change the iProc Kconfig to select THERMAL and THERMAL_OF, which allows
> the ns-thermal driver to be selected via menuconfig.
>
> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
> ---
> arch/arm/mach-bcm/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
> index a0e66d8..da2bfeb 100644
> --- a/arch/arm/mach-bcm/Kconfig
> +++ b/arch/arm/mach-bcm/Kconfig
> @@ -19,6 +19,8 @@ config ARCH_BCM_IPROC
> select GPIOLIB
> select ARM_AMBA
> select PINCTRL
> + select THERMAL
> + select THERMAL_OF
This is NSP specific at this point. Also, If it increases code size in
any way it shouldn't be selected for all IPROC SoCS. I'd rather this
was just selected via defconfig
> help
> This enables support for systems based on Broadcom IPROC architected SoCs.
> The IPROC complex contains one or more ARM CPUs along with common
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/3] ARM: BCM: Enable thermal support for iProc SoCs
2017-04-27 23:10 ` Scott Branden
@ 2017-04-28 18:05 ` Jon Mason
0 siblings, 0 replies; 6+ messages in thread
From: Jon Mason @ 2017-04-28 18:05 UTC (permalink / raw)
To: Scott Branden
Cc: Florian Fainelli, Zhang Rui, Eduardo Valentin, Rob Herring,
Mark Rutland, BCM Kernel Feedback, linux-arm-kernel, open list,
linux-pm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Thu, Apr 27, 2017 at 7:10 PM, Scott Branden
<scott.branden@broadcom.com> wrote:
>
>
> On 17-04-27 02:23 PM, Jon Mason wrote:
>>
>> Change the iProc Kconfig to select THERMAL and THERMAL_OF, which allows
>> the ns-thermal driver to be selected via menuconfig.
>>
>> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
>> ---
>> arch/arm/mach-bcm/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
>> index a0e66d8..da2bfeb 100644
>> --- a/arch/arm/mach-bcm/Kconfig
>> +++ b/arch/arm/mach-bcm/Kconfig
>> @@ -19,6 +19,8 @@ config ARCH_BCM_IPROC
>> select GPIOLIB
>> select ARM_AMBA
>> select PINCTRL
>> + select THERMAL
>> + select THERMAL_OF
>
> This is NSP specific at this point. Also, If it increases code size in any
> way it shouldn't be selected for all IPROC SoCS. I'd rather this was just
> selected via defconfig
This isn't selectable via menuconfig without being in the kconfig.
I'll move it to the NSP portion of the kconfig, as to not increase the
size of other's kernels.
Thanks,
Jon
>
>> help
>> This enables support for systems based on Broadcom IPROC
>> architected SoCs.
>> The IPROC complex contains one or more ARM CPUs along with
>> common
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 2/3] thermal: broadcom: ns-thermal: default on iProc SoCs
2017-04-27 21:23 [PATCH v2 0/3] thermal: broadcom: Add NSP Thermal Support Jon Mason
2017-04-27 21:23 ` [PATCH v2 1/3] ARM: BCM: Enable thermal support for iProc SoCs Jon Mason
@ 2017-04-27 21:23 ` Jon Mason
2017-04-27 21:23 ` [PATCH v2 3/3] ARM: dts: NSP: Add Thermal Support Jon Mason
2 siblings, 0 replies; 6+ messages in thread
From: Jon Mason @ 2017-04-27 21:23 UTC (permalink / raw)
To: Florian Fainelli, Zhang Rui, Eduardo Valentin, Rob Herring, Mark Rutland
Cc: bcm-kernel-feedback-list, linux-arm-kernel, linux-kernel,
linux-pm, devicetree
Tweak the Kconfig description to mention support for NSP and make the
default on for iProc based platforms.
Signed-off-by: Jon Mason <jon.mason@broadcom.com>
---
drivers/thermal/broadcom/Kconfig | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/thermal/broadcom/Kconfig b/drivers/thermal/broadcom/Kconfig
index f0dea8a..26d706c 100644
--- a/drivers/thermal/broadcom/Kconfig
+++ b/drivers/thermal/broadcom/Kconfig
@@ -1,8 +1,9 @@
config BCM_NS_THERMAL
tristate "Northstar thermal driver"
depends on ARCH_BCM_IPROC || COMPILE_TEST
+ default ARCH_BCM_IPROC
help
- Northstar is a family of SoCs that includes e.g. BCM4708, BCM47081,
- BCM4709 and BCM47094. It contains DMU (Device Management Unit) block
- with a thermal sensor that allows checking CPU temperature. This
- driver provides support for it.
+ Support for the Northstar and Northstar Plus family of SoCs (e.g.
+ BCM4708, BCM4709, BCM5301x, BCM95852X, etc). It contains DMU (Device
+ Management Unit) block with a thermal sensor that allows checking CPU
+ temperature.
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 3/3] ARM: dts: NSP: Add Thermal Support
2017-04-27 21:23 [PATCH v2 0/3] thermal: broadcom: Add NSP Thermal Support Jon Mason
2017-04-27 21:23 ` [PATCH v2 1/3] ARM: BCM: Enable thermal support for iProc SoCs Jon Mason
2017-04-27 21:23 ` [PATCH v2 2/3] thermal: broadcom: ns-thermal: default on " Jon Mason
@ 2017-04-27 21:23 ` Jon Mason
2 siblings, 0 replies; 6+ messages in thread
From: Jon Mason @ 2017-04-27 21:23 UTC (permalink / raw)
To: Florian Fainelli, Zhang Rui, Eduardo Valentin, Rob Herring, Mark Rutland
Cc: bcm-kernel-feedback-list, linux-arm-kernel, linux-kernel,
linux-pm, devicetree
Add thermal support via the ns-thermal driver and create a single
thermal zone for the entire SoC.
Signed-off-by: Jon Mason <jon.mason@broadcom.com>
Acked-by: Eduardo Valentin <edubezval@gmail.com>
---
arch/arm/boot/dts/bcm-nsp.dtsi | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi
index 832795b..be6fcfb 100644
--- a/arch/arm/boot/dts/bcm-nsp.dtsi
+++ b/arch/arm/boot/dts/bcm-nsp.dtsi
@@ -383,6 +383,12 @@
<0x3f408 0x04>;
};
+ thermal: thermal@3f2c0 {
+ compatible = "brcm,ns-thermal";
+ reg = <0x3f2c0 0x10>;
+ #thermal-sensor-cells = <0>;
+ };
+
sata_phy: sata_phy@40100 {
compatible = "brcm,iproc-nsp-sata-phy";
reg = <0x40100 0x340>;
@@ -533,4 +539,24 @@
brcm,pcie-msi-inten;
};
};
+
+ thermal-zones {
+ cpu-thermal {
+ polling-delay-passive = <0>;
+ polling-delay = <1000>;
+ coefficients = <(-556) 418000>;
+ thermal-sensors = <&thermal>;
+
+ trips {
+ cpu-crit {
+ temperature = <125000>;
+ hysteresis = <0>;
+ type = "critical";
+ };
+ };
+
+ cooling-maps {
+ };
+ };
+ };
};
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread