linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "dan.j.williams@intel.com" <dan.j.williams@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dave.jiang@intel.com" <dave.jiang@intel.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
	"vishal.l.verma@intel.com" <vishal.l.verma@intel.com>
Subject: Re: [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison()
Date: Mon, 1 May 2017 15:05:46 +0000	[thread overview]
Message-ID: <1493651145.30303.13.camel@hpe.com> (raw)
In-Reply-To: <CAPcyv4jQGiDEW6QJYi3EeF5f0UkC=FEx4uA-K+_RaEN-JpZGEw@mail.gmail.com>

On Fri, 2017-04-28 at 17:35 -0700, Dan Williams wrote:
> On Fri, Apr 28, 2017 at 5:12 PM, Dan Williams <dan.j.williams@intel.c
> om> wrote:
> > On Fri, Apr 28, 2017 at 5:10 PM, Dan Williams <dan.j.williams@intel
> > .com> wrote:
> > > On Thu, Apr 27, 2017 at 3:57 PM, Toshi Kani <toshi.kani@hpe.com>
> > > wrote:
> > > > Badblocks are tracked at both region and device levels.
> > > > pmem_clear_poison() and nsio_rw_bytes() call
> > > > nvdimm_clear_poison() and then badblocks_clear() to clear
> > > > badblocks at the device level. However, it does not update
> > > > badblocks at the region level, which makes them inconsistent.
> > > > 
> > > > Change nvdimm_clear_poison() to update backblocks at the region
> > > > level to keep them consistent.
> > > > 
> > > > Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> > > > Cc: Dan Williams <dan.j.williams@intel.com>
> > > > Cc: Dave Jiang <dave.jiang@intel.com>
> > > > Cc: Vishal Verma <vishal.l.verma@intel.com>
> > > 
> > > This looks good, and it seems we have a bug in the other location
> > > that does this in __nd_ioctl(). That other one is missing the
> > > "clear_err.cleared / 512" check. Can you respin this and define a
> > > common helper that both locations can call?
> > 
> > On second thought, I'll take this and spin my own cleanup / fix on
> > top.
> > 
> > Thanks Toshi!
> 
> ...and I need to drop it again because it causes this:
> 
> [  106.974889] BUG: sleeping function called from invalid context at
> kernel/locking/mutex.c:747
> [  106.977328] in_atomic(): 1, irqs_disabled(): 0, pid: 5584, name:
> dd

Sorry, I should have tested with CONFIG_DEBUG_ATOMIC_SLEEP set.  Thanks
for straighten it out in your patch! 

-Toshi 

  reply	other threads:[~2017-05-01 15:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27 22:57 [PATCH 1/2] libnvdimm: fix clear length of nvdimm_forget_poison() Toshi Kani
2017-04-27 22:57 ` [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison() Toshi Kani
2017-04-29  0:10   ` Dan Williams
2017-04-29  0:12     ` Dan Williams
2017-04-29  0:35       ` Dan Williams
2017-05-01 15:05         ` Kani, Toshimitsu [this message]
2017-04-28 21:48 ` [PATCH 1/2] libnvdimm: fix clear length of nvdimm_forget_poison() Dan Williams
2017-04-28 22:29   ` Kani, Toshimitsu
2017-04-28 22:39     ` Dan Williams
2017-04-28 22:41       ` Kani, Toshimitsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493651145.30303.13.camel@hpe.com \
    --to=toshi.kani@hpe.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@ml01.01.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).