From: Ritesh Raj Sarraf <rrs@debian.org>
To: Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Platform Driver <platform-driver-x86@vger.kernel.org>,
Ike Panhc <ike.pan@canonical.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state
Date: Mon, 01 May 2017 23:57:27 +0530 [thread overview]
Message-ID: <1493663247.10973.1.camel@debian.org> (raw)
In-Reply-To: <20170501160543.GA29387@fury>
[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]
On Mon, 2017-05-01 at 09:05 -0700, Darren Hart wrote:
> > sysfs ABI for drivers that provide input interface is quite strong for
> > my opinion. It means I'm not totally objecting, but I would accept it
> > if and only if there is nothing else could be done.
>
> Agreed, we've recently wanted to remove certain sysfs attributes from another
> driver as they were obsolete and better implemented in other ways, but once
> they
> are there, are hands are tied.
>
> That said, we will support getting these systems functional. From what I see
> in
> the patch you are implementing a polling sysfs interface. Have you verified
> that
> there is no event we can capture and send the SW_TABLET_MODE along to the
> input
> system?
I believe it does generate an event (at least on my Yoga 2 13 variant). IIRC,
when I talked to Andy initially about the driver's limitation, we did do an
exercise [1] to determine if an event was generated.
Cooking this patch (sysfs interface) was much quicker and easy. I looked at the
other example drivers, that do SW_TABLET_MODE, but left it there. I don't think
I have all the necessary information to get that done for the ideapad driver.
[1] https://patchwork.kernel.org/patch/9546987/
--
Ritesh Raj Sarraf | http://people.debian.org/~rrs
Debian - The Universal Operating System
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-05-01 18:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 18:47 [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state Ritesh Raj Sarraf
2017-02-22 10:24 ` Ritesh Raj Sarraf
2017-03-01 23:16 ` Andy Shevchenko
2017-04-28 19:17 ` Andy Shevchenko
2017-04-29 6:52 ` Ritesh Raj Sarraf
2017-04-30 12:54 ` Andy Shevchenko
2017-05-01 16:05 ` Darren Hart
2017-05-01 18:27 ` Ritesh Raj Sarraf [this message]
2017-05-01 19:16 ` Darren Hart
2017-05-03 14:36 ` Ritesh Raj Sarraf
2017-05-03 14:42 ` Andy Shevchenko
2017-05-03 16:11 ` Darren Hart
2017-05-07 11:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493663247.10973.1.camel@debian.org \
--to=rrs@debian.org \
--cc=andy.shevchenko@gmail.com \
--cc=dvhart@infradead.org \
--cc=ike.pan@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).