From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Mike Christie <mchristi@redhat.com>
Cc: Xiubo Li <lixiubo@cmss.chinamobile.com>,
agrover@redhat.com, iliastsi@arrikto.com, namei.unix@gmail.com,
sheng@yasker.org, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
Jianfei Hu <hujianfei@cmss.chinamobile.com>
Subject: Re: [PATCH v6 2/2] tcmu: Add global data block pool support
Date: Mon, 01 May 2017 22:26:24 -0700 [thread overview]
Message-ID: <1493702784.23202.64.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <59078120.3000200@redhat.com>
On Mon, 2017-05-01 at 13:40 -0500, Mike Christie wrote:
> On 04/30/2017 06:29 AM, Xiubo Li wrote:
> > [...]
<SNIP>
> >> To avoid starvation, I think you want a second list/fifo that holds the
> >> watiers. In tcmu_get_empty_block if the list is not empty, record how
> >> many pages we needed and then add the device to the list and wait in
> >> tcmu_queue_cmd_ring.
> >>
> >> Above if we freed enough pages for the device at head then wake up the
> >> device.
> >>
> >> I think you also need a wake_up call in the completion path in case the
> >> initial call could not free enough pages. It could probably check if the
> >> completion was going to free enough pages for a waiter and then call
> >> wake.
> >>
> > Yes, I meant to introduce this later after this series to not let the
> > patches too
> > complex to review.
> >
> > If you agree I will do this later, or in V7 series ?
>
>
> Yeah, I am ok with adding it after the initial patches go in.
Btw, adding your Acked-by for the initial merge of these.
If that's a problem, please make some noise. ;)
next prev parent reply other threads:[~2017-05-02 5:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 6:25 [PATCH v6 0/2] tcmu: Dynamic growing data area support lixiubo
2017-04-26 6:25 ` [PATCH v6 1/2] tcmu: Add dynamic growing data area feature support lixiubo
2017-04-30 5:48 ` Mike Christie
2017-04-30 10:22 ` [PATCH v6 1/2] tcmu: Add dynamic growing data area featuresupport Xiubo Li
2017-05-01 18:37 ` Mike Christie
2017-04-26 6:25 ` [PATCH v6 2/2] tcmu: Add global data block pool support lixiubo
2017-04-26 10:07 ` kbuild test robot
2017-04-30 7:31 ` Mike Christie
2017-04-30 11:29 ` Xiubo Li
2017-05-01 18:40 ` Mike Christie
2017-05-02 5:26 ` Nicholas A. Bellinger [this message]
2017-05-02 5:25 ` [PATCH v6 0/2] tcmu: Dynamic growing data area support Nicholas A. Bellinger
2017-05-02 9:25 ` 答复: " lixiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493702784.23202.64.camel@haakon3.risingtidesystems.com \
--to=nab@linux-iscsi.org \
--cc=agrover@redhat.com \
--cc=hujianfei@cmss.chinamobile.com \
--cc=iliastsi@arrikto.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lixiubo@cmss.chinamobile.com \
--cc=mchristi@redhat.com \
--cc=namei.unix@gmail.com \
--cc=sheng@yasker.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).