From: Rik van Riel <riel@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, lvenanci@redhat.com, lwang@redhat.com,
efault@gmx.de, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/14] sched/topology,debug: Verify the first group matches the child domain
Date: Wed, 03 May 2017 11:00:16 -0400 [thread overview]
Message-ID: <1493823616.20270.0.camel@redhat.com> (raw)
In-Reply-To: <20170502145224.GC4626@worktop.programming.kicks-ass.net>
[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]
On Tue, 2017-05-02 at 16:52 +0200, Peter Zijlstra wrote:
> On Mon, May 01, 2017 at 05:13:26PM -0400, Rik van Riel wrote:
> > On Fri, 2017-04-28 at 15:20 +0200, Peter Zijlstra wrote:
> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> >
> > This could use a changelog.
>
> Yes indeed... I put off writing one because $hard, and clearly I
> forgot
> entirely :-/
>
> How's this?
Looks good to me.
> ---
> Subject: sched/topology,debug: Verify the first group matches the
> child domain
> From: Peter Zijlstra <peterz@infradead.org>
> Date: Fri Apr 14 18:20:48 CEST 2017
>
> We want sched_groups to be sibling child domains (or individual CPUs
> when there are no child domains). Furthermore, since the first group
> of a domain should include the CPU of that domain, the first group of
> each domain should match the child domain.
>
> Verify this is indeed so.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2017-05-03 15:00 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 13:19 [PATCH 00/14] sched/topology fixes Peter Zijlstra
2017-04-28 13:19 ` [PATCH 01/14] sched/topology: Refactor function build_overlap_sched_groups() Peter Zijlstra
2017-04-28 13:20 ` [PATCH 02/14] sched,cpumask: Export for_each_cpu_wrap() Peter Zijlstra
2017-05-01 19:56 ` Rik van Riel
2017-04-28 13:20 ` [PATCH 03/14] sched/topology: Fix building of overlapping sched-groups Peter Zijlstra
2017-05-01 20:08 ` Rik van Riel
2017-04-28 13:20 ` [PATCH 04/14] sched/topology: Simplify build_overlap_sched_groups() Peter Zijlstra
2017-05-01 21:04 ` Rik van Riel
2017-04-28 13:20 ` [PATCH 05/14] sched/topology,debug: Print the group mask Peter Zijlstra
2017-05-01 21:13 ` Rik van Riel
2017-04-28 13:20 ` [PATCH 06/14] sched/topology,debug: Verify the first group matches the child domain Peter Zijlstra
2017-05-01 21:13 ` Rik van Riel
2017-05-02 14:52 ` Peter Zijlstra
2017-05-03 15:00 ` Rik van Riel [this message]
2017-04-28 13:20 ` [PATCH 07/14] sched/topology: Optimize build_group_mask() Peter Zijlstra
2017-05-02 0:57 ` Rik van Riel
2017-04-28 13:20 ` [PATCH 08/14] sched/topology: Move comment about asymmetric node setups Peter Zijlstra
2017-05-02 1:08 ` Rik van Riel
2017-04-28 13:20 ` [PATCH 09/14] sched/topology: Remove FORCE_SD_OVERLAP Peter Zijlstra
2017-05-02 1:09 ` Rik van Riel
2017-04-28 13:20 ` [PATCH 10/14] sched/topology: Fix overlapping sched_group_mask Peter Zijlstra
2017-04-28 13:20 ` [PATCH 11/14] sched/topology: Small cleanup Peter Zijlstra
2017-04-28 13:20 ` [PATCH 12/14] sched/topology,debug: Add sched_group_capacity debugging Peter Zijlstra
2017-04-28 13:20 ` [PATCH 13/14] sched/topology: Fix overlapping sched_group_capacity Peter Zijlstra
2017-04-28 13:20 ` [PATCH 14/14] sched/topology: Add a few comments Peter Zijlstra
2017-05-01 8:35 ` Peter Zijlstra
2017-04-28 13:53 ` [PATCH 00/14] sched/topology fixes Peter Zijlstra
2017-04-28 23:30 ` Lauro Venancio
2017-05-01 8:57 ` Peter Zijlstra
2017-05-02 14:43 ` Peter Zijlstra
2017-05-02 14:54 ` Lauro Venancio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493823616.20270.0.camel@redhat.com \
--to=riel@redhat.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lvenanci@redhat.com \
--cc=lwang@redhat.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).